Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp audio wizard #4100

merged 7 commits into from Apr 24, 2020


Copy link

This PR improves the appearance of the AudioWizard by performing the following steps:

This is how the positional audio showcase renders after this PR:


| Improved: Appearance & Accessibility of AudioWizard

mkrautz and others added 6 commits April 23, 2020 18:49

Previously the drawn circles where extremely small and totally
pixelated. Furthermore the filling of the circles didn't work (it only
filled a single pixel in the center). This all is fixed by this commit.
…io showcase

This commit decreases the speed at which the audio source rotates around
the user in order for the user to have anough time to notice the change
in audio. At the speed the source was moving before it was rather hard
to follow what's going on.

Even though the wizard has a cancel button, it seems as if some users
are unsure whether cancelling the wizard might mess up their settings
(see mumble-voip#4002). Therefore this commit adds a statement to the first page of
the wizard that it is indeed safe to cancel it.
This addresses mumble-voip#4002 in which it was requested for all explanatory texts
to be selectable in order to process them non-visually. Thus this should
increase the accessibility of the AudioWizard.
Updating 'mumble_en.ts'...
    Found 1744 source text(s) (2 new and 1742 already existing)
    Removed 2 obsolete entries
@Krzmbrzl Krzmbrzl merged commit 08a4640 into mumble-voip:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Make explanatory texts selectable and copyable Audio Wizard (Positional Audio): Yellow text unreadable
2 participants