Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DBus methods for setting/querying the current transmit mode #4119

Merged
merged 1 commit into from May 7, 2020

Conversation

darkwater
Copy link

@darkwater darkwater commented May 1, 2020

This lets users control their transmit mode through DBus.

Changelog

| Added: DBus interface for setting/querying current transmission mode

src/mumble/DBus.cpp Outdated Show resolved Hide resolved
src/mumble/DBus.h Outdated Show resolved Hide resolved
src/mumble/MainWindow.h Outdated Show resolved Hide resolved
@Krzmbrzl Krzmbrzl added the client label May 1, 2020
@Krzmbrzl
Copy link
Member

Krzmbrzl commented May 1, 2020

Oh and while you're at it: Please change your commit message to be something like:

src/mumble/DBus: Added methods for setting/querying the current transmission mode

src/mumble/DBus.cpp Outdated Show resolved Hide resolved
src/mumble/DBus.cpp Outdated Show resolved Hide resolved
@Krzmbrzl
Copy link
Member

Krzmbrzl commented May 6, 2020

I'll have to check whats wrong with the CI. It seems unrelated to your changes though...

@Krzmbrzl
Copy link
Member

Krzmbrzl commented May 7, 2020

I force-pushed your branch in order to incorporate the fixes needed for the CI...

@Krzmbrzl Krzmbrzl added this to the 1.4.0 milestone May 7, 2020
@Krzmbrzl Krzmbrzl merged commit bc112e5 into mumble-voip:master May 7, 2020
@Krzmbrzl
Copy link
Member

Krzmbrzl commented May 7, 2020

Thank you very much for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants