Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to add custom window title extension #4155

Merged
merged 3 commits into from May 17, 2020

Conversation

Krzmbrzl
Copy link
Member

@Krzmbrzl Krzmbrzl commented May 10, 2020

In #4153 it was requested to have an option that allows to customize the
window title in order to better differentiate between the windows of
multiple Mumble instances.

This commit allows just that by letting the user specify a postfix
that'll be appended to the window title.

Fixes #4153

Changelog

| Added --window-title-ext to set a custom window title extension

@Krzmbrzl Krzmbrzl added this to the 1.4.0 milestone May 10, 2020
src/mumble/main.cpp Outdated Show resolved Hide resolved
@Krzmbrzl Krzmbrzl force-pushed the window-title-cli-option branch 2 times, most recently from c7092ae to 49cef50 Compare May 11, 2020 05:58
@streaps
Copy link

streaps commented May 11, 2020

--post-title

I would prefer --window-title, it's self-explanatory. --post-title sounds more like the title of a (blog) post. Also not everybody might understand what a "custom window title postfix" is.

@Krzmbrzl
Copy link
Member Author

I would prefer --window-title, it's self-explanatory.

It's not. Actually it's even misleading. This is why I didn't use it.
This option does not allow you to specify a window title. It allows you to set a postfix string that'll be appended to the window title.

Also not everybody might understand what a "custom window title postfix" is.

That could happen, yes... Any suggestion for a better explanation?
IN the worst case though I think people can simply try it out and see what it does ^^

@streaps
Copy link

streaps commented May 11, 2020

I would prefer --window-title, it's self-explanatory.

It's not. Actually it's even misleading.

I wouldn't call it misleading, but better slightly misleading than incomprehensible at first sight.

This option does not allow you to specify a window title. It allows you to set a postfix string that'll be appended to the window title.

I still would have to try it to see what that means. I also wouldn't mind if it really would set the complete window title, without any prefix. If a user wants Mumble in the title, they could still include it.

Also not everybody might understand what a "custom window title postfix" is.

That could happen, yes... Any suggestion for a better explanation?

--window-title
Set "Mumble -- " as the window title.

@Krzmbrzl
Copy link
Member Author

@streaps what do you think about --title-extension (or --window-title-ext) with the description Sets a custom window title extension?

@streaps
Copy link

streaps commented May 13, 2020

Both are fine. I'm undecided, which I would prefer :).

@Krzmbrzl Krzmbrzl changed the title Added option to add custom window title postfix Added option to add custom window title extension May 13, 2020
Krzmbrzl and others added 3 commits May 14, 2020 20:09
In mumble-voip#4153 it was requested to have an option that allows to customize the
window title in order to better differentiate between the windows of
multiple Mumble instances.

This commit allows just that by letting the user specify a postfix
that'll be appended to the window title.

Co-authored-by: Davide Beatrici <davidebeatrici@gmail.com>
Updating 'mumble_en.ts'...
    Found 1755 source text(s) (1 new and 1754 already existing)
    Removed 1 obsolete entries
@Krzmbrzl Krzmbrzl merged commit 2f3b2df into mumble-voip:master May 17, 2020
@toby63
Copy link
Contributor

toby63 commented May 18, 2020

--window-title-ext

Is the best choice imo, thanks for choosing that 👍

@Krzmbrzl Krzmbrzl deleted the window-title-cli-option branch November 9, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A command line option to set the window title
4 participants