New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to add custom window title extension #4155
Added option to add custom window title extension #4155
Conversation
c7092ae
to
49cef50
Compare
I would prefer |
It's not. Actually it's even misleading. This is why I didn't use it.
That could happen, yes... Any suggestion for a better explanation? |
I wouldn't call it misleading, but better slightly misleading than incomprehensible at first sight.
I still would have to try it to see what that means. I also wouldn't mind if it really would set the complete window title, without any prefix. If a user wants Mumble in the title, they could still include it.
--window-title |
@streaps what do you think about |
Both are fine. I'm undecided, which I would prefer :). |
49cef50
to
c3d6b1e
Compare
…tion without argument
In mumble-voip#4153 it was requested to have an option that allows to customize the window title in order to better differentiate between the windows of multiple Mumble instances. This commit allows just that by letting the user specify a postfix that'll be appended to the window title. Co-authored-by: Davide Beatrici <davidebeatrici@gmail.com>
Updating 'mumble_en.ts'... Found 1755 source text(s) (1 new and 1754 already existing) Removed 1 obsolete entries
c3d6b1e
to
4c1761b
Compare
Is the best choice imo, thanks for choosing that |
In #4153 it was requested to have an option that allows to customize the
window title in order to better differentiate between the windows of
multiple Mumble instances.
This commit allows just that by letting the user specify a postfix
that'll be appended to the window title.
Fixes #4153
Changelog