New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tooltip for echo cancellation #4174
Conversation
Updating 'mumble_en.ts'... Found 1773 source text(s) (1 new and 1772 already existing) Removed 1 obsolete entries
Ok, a good start, but still some things could be improved:
|
I think "speaker" is important to mention. If you are using the a headphone for listening to the "audio output" echo might not be a problem at all. I understand an audio output as something where I can plug in a cable (physical or virtual) or a device. The thing that transmits sound over the air to the microphone is a speaker or multiple speakers. I agree the explanation could be simpler with fewer technical terms. I wonder how much CPU is used by the multichannel echo canceller. If it is negligible the recommendation (and the default setting) could be different. |
Okay, CPU usage is still a problem: #4177 |
See #4178 for reasons why I think echo cancellation should be enabled by default. |
Btw, it's called acoustic echo cancellation (AEC). |
In general I agree, but I don't know if everyone understands speaker correctly... Regarding the tooltip, maybe we could use a combination of practical and technical description:
Edit: added "loudspeaker" as replacement for speakers- |
maybe "loudspeaker" is less ambiguous than speaker in this case. |
@streaps @toby63 I agree that the tooltip could probably be improved. I was just happy to have found an explanation so I immediately used that ^^ I think this would be an excellent place for you guys to create a PR of your own. After all it's your thoughts that are currently going into improving the tooltip. The relevant code are you can see from this PR :) |
Ok, will probably add a pull request, hope that works Just in case I will post the result also here (only as text of course). |
I don't think that's necessary :) |
I just noticed something: Maybe a better idea would be to add a button behind the echo cancel-options, like: But it's your decision, if you want a tooltip I will release a pull request for it. |
I agree that it is longer but we use tooltips everywhere else so I think it'd be kinda a break of style if we add an info button for this entry |
I don't think so, you could still have a tooltip (just like before "describing the obvious" I think you could (and maybe should) add also more of those buttons, to explain other audio options as well. |
We can do stuff like that once we have cleared the pipelines of more pressing issues. There are multiple issues about how the UI could be enhanced already but we just don't have the time to prioritize it.... |
One question related to #4279: |
No - only normal tooltip |
This tooltip explains the difference between mixed and multichannel echo cancellation.
Most of the wording and the info comes from @fedetft
Fixes #4125