Move positional audio option to proper section #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide a screenshot, please? |
…tion We do have a separate section in the AudioOutput settings for positional audio but the option to enable/disable it is not in that section. This doesn't make a whole lot of sense. This commit simply moves the setting into the positional audio section and also renames it from "positional audio" to "enable" as due to its location in the settings, it's clear what it'll be about.
Updating 'mumble_en.ts'...
Found 1870 source text(s) (1 new and 1869 already existing)
Krzmbrzl
force-pushed
the
move-positionalAudio-setting
branch
from
0514e77
to
b71c263
Compare
|
@davidebeatrici I added them in the PR's description. While taking them I also found a bug that is now fixed (having PA disabled would also disable the enable-button making it impossible to turn it (back) on) |
|
Hahahaha This is great I love it! |
|
Positional audio looks good. Slightly OT: having the attenuation settings split up in three sections doesn't make much sense. |
davidebeatrici
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We do have a separate section in the AudioOutput settings for positional
audio but the option to enable/disable it is not in that section. This
doesn't make a whole lot of sense.
This commit simply moves the setting into the positional audio section
and also renames it from "positional audio" to "enable" as due to its
location in the settings, it's clear what it'll be about.
Before
After