Allow disabling of TTS for specific users #4287
Conversation
|
a screenshot would be helpful |
|
|
There was a problem hiding this comment.
Apart from that signal-thingy, this LGTM.
Please have a look at our commit guidelines though: https://github.com/mumble-voip/mumble/blob/master/COMMIT_GUIDELINES.md
If possible, it'd be nice if you could adapt your commits accoridngly (squash everything but the translation update into a single FEAT(tts) commit.
You don't have to re-formulate the translation update commit though
Ah shiet I used |
These changes make it possible to turn of TTS for a specific user while still receiving their messages. This setting can be managed from the context menu of a user that is connected to the server and is only visible when TTS is enabled globally. A new DB table called 'ignored_tts' had to be created to persist this setting.
Updating 'mumble_en.ts'...
Found 1873 source text(s) (4 new and 1869 already existing)
|
I changed the commit message to be |
|
Thank you for your contribution :) |
|
Just FYI: We have forgotten to check for null at some point - see #4307 :) |
…om server 1a4d134 (part of #4287) introduced the ability to disable TTS for specific users. The change however didn't account for messages that are sent from the server. In these cases pSrc is nullptr but that commit introduced code that access it without checking for null. This lead to a SegFault as soon as a text message from the server is received. This commit fixes this by simply adding a null-check before accessing the variable.
|
how do i use this feature? i don't see it in release 1.3.4 or in the latest 1.4.0 development snapshot. |
|
That it is not in the 1.3.x series is expected (we don't backport new features) but it should be present in the 1.4.0 snapshots. |
|
it says i'm using the development snapshot. i've tried on both windows and macos. |
|
The button will only show if you actually have TTS enabled in the first place. Is that the case? mumble/src/mumble/MainWindow.cpp Lines 1568 to 1569 in 937f4e2 |
These changes make it possible to disable Text-To-Speech for specific
users while still receiving the messages as normal text.
A use case for this would be muting text to speech for a music bot.