FIX(tts): OmitScope/OmitAuthor no longer reads HTML-formatted message #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popkornium18
commented
Jun 23, 2020
|
Wtf why are Mac and Windows complaining about forward declaration but Linux compiles fine? 🤔 |
Welcome to c++'s compiler hell where every compiler works (slightly) differently 🤷 |
Krzmbrzl
added
accessibility
The new features "Omit Message Scope" and "Omit Message Author" where somewhat broken. The problems are adressed by transforming the message from HTML to plaintext and creating a new TTS string that either contains no prefix or just the scope or the author. Fixes #4309
Updating 'mumble_en.ts'...
Found 1881 source text(s) (5 new and 1876 already existing)
Removed 4 obsolete entries
|
Thanks for fixing this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new features "Omit Message Scope" and "Omit Message Author" where
somewhat broken.
The problems are adressed by transforming the message from HTML to
plaintext and creating a new TTS string that either contains no prefix
or just the scope or the author.
Fixes #4309