FEAT(client): Allow specifying config file via commandline switch #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popkornium18
commented
Jul 16, 2020
Popkornium18
commented
Jul 16, 2020
|
I'd like to add some documentation for this to the man page. Since there are already a lot of other commandline arguments that are not documented in the man page, I thought this would be another PR. Or is there a reason why they are not mentioned in the man page? |
|
We have a man-page? Updating the man page does indeed sound like a good candidate for another PR |
Krzmbrzl
requested changes
Jul 26, 2020
|
I made all the changes you requested. |
Krzmbrzl
reviewed
Aug 1, 2020
This adds the switch -c/--config to the mumble client. If -c is followed by a filename, this file will be read instead of the standard config. A new config option database= has been added to the 'General' section of the ini file. This can be used to specify a different database which is necessary to run multiple completely separate Mumble instances at the same time. Additionaly the (undocumented) function to merge another ini file by providing it as a parameter has been removed as it was conflicting with the added functionality. FIXES #3953
Updating 'mumble_en.ts'...
Found 1891 source text(s) (4 new and 1887 already existing)
Removed 2 obsolete entries
Krzmbrzl
approved these changes
Aug 4, 2020
|
Thank you for your work! :) |
|
is this in 1.3.3? |
|
No. As this is a new feature, it will not get backported. That means that it'll be part of 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This adds the switch -c/--config to the mumble client. If -c is followed by a filename, this file will be read instead of the standard config.
A new config option
database=has been added to the 'General' section of the ini file. This can be used to specify a different database which is necessary to run multiple completely separate Mumble instances at the same time.Additionaly the (undocumented) function to merge another ini file by providing it as a parameter has been removed as it was conflicting with the added functionality.
FIXES #3953