Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT(client, mainwindow): Show volume adjustments #4439

Merged

Conversation

Krzmbrzl
Copy link
Member

@Krzmbrzl Krzmbrzl commented Aug 27, 2020

This feature optionally allows users to display the set volume
adjustments next to the user's/listener's name.
It will only be shown if it is not equal to 0 dB (aka: it is actually
having an effect).

By default this option is enabled since it is only visible if volume
adjustments are set up anyways.

Screenshot:
Mumble_ShowVolumeAdjustments

@Krzmbrzl Krzmbrzl added client ui feature-request This issue or PR deals with a new feature labels Aug 27, 2020
A ClientUser object will now emit a signal every time its local volume
adjustment is being changed.
This feature optionally allows users to display the set volume
adjustments next to the user's/listener's name.
It will only be shown if it is not equal to 0 dB (aka: it is actually
having an effect).

By default this option is enabled since it is only visible if volume
adjustments are set up anyways.
Updating 'mumble_en.ts'...
    Found 1893 source text(s) (2 new and 1891 already existing)
@Krzmbrzl Krzmbrzl force-pushed the feat-makeVolumeAdjustmentsMoreVisible branch from 12a7257 to 7c1f1c9 Compare August 29, 2020 14:51
@Krzmbrzl Krzmbrzl merged commit ade9e9e into mumble-voip:master Aug 29, 2020
Krzmbrzl added a commit that referenced this pull request Sep 15, 2020
This is a followup on #4439 (and #4436) that fixes 2 issues of that implementation:

    Wrong volume adjustments being displayed for ChannelListeners in certain situations
    MainWindow not updating automatically when the adjustments change
@Krzmbrzl Krzmbrzl deleted the feat-makeVolumeAdjustmentsMoreVisible branch November 9, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant