Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(client, audio): Loading sample fails silently #4497

Merged

Conversation

Krzmbrzl
Copy link
Member

If a sound-file failed to load, there is no hint about this in the logs
or anywhere else as it never actually gets ensured that the loading was
successful.

Now and explicit check is performed and if the loading failed, a warning
is printed to the console.

Closes #4492

If a sound-file failed to load, there is no hint about this in the logs
or anywhere else as it never actually gets ensured that the loading was
successful.

Now and explicit check is performed and if the loading failed, a warning
is printed to the console.

Closes mumble-voip#4492
@Krzmbrzl Krzmbrzl merged commit 42e3752 into mumble-voip:master Sep 21, 2020
@Krzmbrzl Krzmbrzl deleted the fix-soundFileLoadingFailsSilently branch November 9, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question regarding default soundpack
1 participant