FEAT(client): Adds a new shortcut which hides/shows the main window #4562
Conversation
There was a problem hiding this comment.
Thanks for the changes!
Now I'd only ask you to squash your first 2 commits (but keep the translation one separate) into a single one (the commit history of how the review has influenced the code is nothing that has to go into master).
After that I think we're all set
merua
force-pushed
the
master
branch
2 times, most recently
from
a1c41ec
to
062e41f
Compare
src/mumble/MainWindow.cpp
Outdated
| if(down) { | ||
| if(g.mw->isVisible()) { |
There was a problem hiding this comment.
| if(down) { | |
| if(g.mw->isVisible()) { | |
| if (down) { | |
| if (g.mw->isVisible()) { |
Scanning directory './src'...
Scanning directory './src/mumble'...
Updating 'src/mumble/mumble_en.ts'...
Found 1910 source text(s) (1 new and 1909 already existing)
|
Thank you very much for your contribution! |
|
Thanks to you and all the other contributors. I have started using Mumble since the lockdowns and it has really helped staying in touch with my friends, so keep up the good work! (Especially since I found out -- to my horror -- that a lot of problem tickets are written in a very toxic tone.) And next time I will try to set up the formatter. Sorry for that... |
|
Thanks! No worries about the formatting, we should probably add a CI task that runs |
Implements #2328