FIX(client): Respect unlimited imagemessagelength

[merua]

When you set the imagemessagelength to 0 on the server and paste an
image into the client chat no error should pop up that the image is too
large.

[merua]

I really missed pasting images directly into the Mumble chat and thought this is covered by this issue and wanted to work on it. But the current master already implements this so maybe this issue can be closed?

Would it be possible that the client compresses the image to the size the server allows before sending it? Or does that violate any design choices? As a user I wouldn't expect Mumble to transmit images without loss but I find it quite cumbersome to compress them manually before sending it.

[Krzmbrzl]

In the documentation on that config option (https://wiki.mumble.info/wiki/Murmur.ini#imagemessagelength) I don't see any mention of a special treatment if the value is set to 0. Where did you find any evidence that the behavior you implemented is actually intended?
Or is this not a fix but rather a new feature? 🤔

I really missed pasting images directly into the Mumble chat and thought this is covered by this issue and wanted to work on it. But the current master already implements this so maybe this issue can be closed?

Absolutely. Thanks for bringing this to our attention 👍

Would it be possible that the client compresses the image to the size the server allows before sending it?

I guess in principle this should be possible. Afaik though the client does not know the value of this limit and therefore it can't act on it (not 100% sure though).
Thus in order to implement it, the client would first have to fetch that information from the server...

[merua]

I don't see any mention of a special treatment if the value is set to 0. Where did you find any evidence that the behavior you implemented is actually intended?

I found it here.

I guess in principle this should be possible. Afaik though the client does not know the value of this limit and therefore it can't act on it (not 100% sure though).
Thus in order to implement it, the client would first have to fetch that information from the server...

As far as I understood the code the client does fetch the value of this limit (otherwise how would it know to reject a too large image?) and I think it happens here.

[Krzmbrzl]

Ah so the wiki does not contain all information. I added the information there.
Besides I just noticed that (as stated in the title) this PR is only about the client. The server already behaves in this way:

mumble/src/murmur/Messages.cpp

Lines 762 to 766 in dc99acc

	if (iMaxImageMessageLength > 0
	&& (msg.texture().length() > static_cast< unsigned int >(iMaxImageMessageLength))) {
	PERM_DENIED_TYPE(TextTooLong);
	return;
	}

This then of course means that you are absolutely correct by saying that the limit is transferred to the client (and the linked code part should be the correct one for that).

Thanks for the clarification 👍

[Krzmbrzl]

Thank you very much for your contribution! :)

[merua]

Thank you!