FEAT(client): Adds shortcut to listen to a channel #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
requested changes
Dec 18, 2020
There was a problem hiding this comment.
Please ensure that your commit message follows the format specified in our commit guidelines
|
@timjwkim are you going to update this PR or shall I finish it up for you? |
|
My apologies, didn't get a chance to see the updates on this thread til now. |
|
@timjwkim so? |
|
@Krzmbrzl What can I do to push this change forward? |
When storing shortcuts in the database (which happens only for server-specific shortcuts), the assumption has been that the type of the stored shortcut is always "Whisper/Shout" because up to now this is the only shortcut that can be server-specific. However, this approach is not very future-proof, which is why this commit makes sure that from now on, we explicitly store the type of the shortcut as well.
Up to now the logic for clearing shortcut data upon a change in the shortcut config window was to see if the type() of the current data matches that of the shortcut's default data. However, for user-defined types QVariant::type() always returns QVariant::UserType and thus different user-defined types could not be distinguished. If we instead use QVariant::userType(), this problem does no longer exist.
This introduces a new global shortcut that can be used to start or stop listening to a configured channel. Fixes mumble-voip#4486 Co-Authored-By: timjwkim <timjwkim@umich.edu>
Krzmbrzl
approved these changes
Sep 9, 2022
Krzmbrzl
added
client
feature-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a global shortcut that toggles listening to a specific channel targeted by the client.
Fixes #4486