Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT(client): Added DBus calls to toggle mute and deaf state. #4667

Merged
merged 1 commit into from Jan 4, 2021
Merged

FEAT(client): Added DBus calls to toggle mute and deaf state. #4667

merged 1 commit into from Jan 4, 2021

Conversation

robozman
Copy link
Contributor

@robozman robozman commented Jan 3, 2021

I initially tried using the toggle() function, but that did not work.
Reading the check state and setting the same value ended up actually
inverting the state.

@robozman
Copy link
Contributor Author

robozman commented Jan 3, 2021

I also posted a question about the weirdness here in the Mumble [development] room.

@robozman
FEAT(client): Added DBus calls to toggle mute and deaf state.
4ca965b 
Just calling the toggle function is enough to cause the state to
invert.
@robozman
Copy link
Contributor Author

robozman commented Jan 3, 2021

Updated, I chatted with @Krzmbrzl and updated the PR to correspond.

Krzmbrzl
Krzmbrzl approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@Krzmbrzl Krzmbrzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adding the functions here enough to expose them via DBus? 🤔

@Krzmbrzl Krzmbrzl added client feature-request This issue or PR deals with a new feature labels Jan 3, 2021
@robozman
Copy link
Contributor Author

robozman commented Jan 4, 2021 •
edited

Is adding the functions here enough to expose them via DBus?

Apparently 🤷 Here is a screenshot of d-feet with this change
mumble_dbus

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Jan 4, 2021

Okay then 😅 🤷

Thanks for the contribution :)

@Krzmbrzl Krzmbrzl merged commit 391ea23 into mumble-voip:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krzmbrzl Krzmbrzl Krzmbrzl approved these changes

Assignees
No one assigned
Labels
client feature-request This issue or PR deals with a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robozman @Krzmbrzl