Fix url version #4778
Merged
Fix url version #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
approved these changes
Feb 21, 2021
Kissaki
requested changes
Feb 21, 2021
|
As my concern was clarified as not a change by this PR, feel free to ignore my rejection then. I will not be able to do an actual review at least until the end of the week. |
When using URLs that don't explicitly state the version, the comment in code said that in this case we'd assume the version of the currently running Mumble instance. The code however hardcoded 1.2.0. This commit fixes this by doing what the commit suggest.
Before this commit we did not report to the user if the version that was specified in the used URL was invalid. This commit makes sure that the user is notified about an invalid version format.
The if condition for checking a URL's version was barely readable. Therefore the condition was now split into two boolean flags that have proper names and are computed beforehand.
7a96dc4 adapted the used RegEx to include support for build-numbers. This however was done without keeping the option for not specifying a build number (as done for the versions used in Mumble URLs for instance). This commit adapts the RegEx such that the build number is now optional. Fixes mumble-voip#4684
Scanning directory './src'...
Scanning directory './src/mumble'...
Updating 'src/mumble/mumble_en.ts'...
Found 1958 source text(s) (1 new and 1957 already existing)
Krzmbrzl
force-pushed
the
fix-url-version
branch
from
9727a47
to
e2952f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple fixes and refactorings related to the version handling
for versions specified in URLs.
See the individual commits for details
Fixes #4684
Checks