FIX(client): Update rnnoise-src submodule #4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
force-pushed
the
rnnoise-update
branch
from
c250b96
to
c85e4ed
Compare
Krzmbrzl
requested changes
Mar 11, 2021
|
Can we split these two concerns into two separate commits? |
|
What do you mean? |
|
Isn’t this two completely separate concerns?
|
|
No, the heap corruption fix is part of the submodule. |
Kissaki
approved these changes
Mar 11, 2021
davidebeatrici
force-pushed
the
rnnoise-update
branch
from
c85e4ed
to
fcd97e6
Compare
davidebeatrici
changed the title
|
@davidebeatrici the commit message should reference the fixed issue. |
|
I prefer not to do that because in case of force-pushes the related pull request gets spammed. |
|
That doesn't cost us anything though. But by referencing the commit with the issue we get a linked history which is very valuable when someone has to look back at it Besides: There are no other changes needed here and thus there is no force pushing expected anymore. |
This fixes a heap corruption that was originally discovered by PaulDana on #mumble-dev. In addition to that, all upstream changes are integrated. Fixes mumble-voip#4842.
davidebeatrici
force-pushed
the
rnnoise-update
branch
from
fcd97e6
to
a8e0797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes a heap corruption that was originally discovered by @PaulDana on
#mumble-dev.In addition to that, all upstream changes are integrated.