CHANGE(client, macOS): Change echo cancellation strategy #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TerryGeng does this PR look alright to you? |
The current implementation for echo cancellation using Apple's acoustic echo cancellation system has been reported to cause major problems (users no longer being able to transmit any audio) and therefore we disable it by default. Ref: mumble-voip#4912
The implementation as it stands can cause major issues (users not being able to transmit any audio). Ref: mumble-voip#4912
Krzmbrzl
force-pushed
the
change-disable-echo-cancellation-macOS
branch
from
f56f3c9
to
5509aa2
Compare
|
Looks good to me. Thanks for doing this quick patch for me, and sorry for causing all these fusses. 🙏🏻️ |
|
No worries - Without you there wouldn't be echo cancellation on macOS at all, so no harm done. And finding these kind of things is exactly the purpose of these snapshot builds ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation for echo cancellation using Apple's acoustic
echo cancellation system has been reported to cause major problems
(users no longer being able to transmit any audio) and therefore we
disable it by default.
Furthermore we mark the option as experimental so that (hopefully) only
experienced users will use it.
Ref: #4912
Checks