FIX(client): Memory leak in ALSA implementation #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
requested changes
Apr 6, 2021
There was a problem hiding this comment.
Please reword your commit message to follow our commit guidelines.
In this case this should be something like
FIX(client): Memory leak in ALSA implementation
The functions snd_card_get_name and snd_card_get_longname allocate a
String for the caller that needs to be freed once it is no longer needed.
This was not done in the current implementation and thus this was causing
a memory leak.
This commit fixes this by explicitly `free`ing the resources after usage.
Fixes #4910
The functions snd_card_get_name and snd_card_get_longname allocate a String for the caller that needs to be freed once it is no longer needed. This was not done in the current implementation and thus this was causing a memory leak. This commit fixes this by explicitly `free`ing the resources after usage. Fixes mumble-voip#4910 Co-Authored-By: Zero0one1 <summerlinasity@gmail.com> Co-Authored-By: Krzmbrzl <krzmbrzl@gmail.com>
Krzmbrzl
changed the title
Krzmbrzl
approved these changes
Apr 6, 2021
|
Thanks for the fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions snd_card_get_name and snd_card_get_longname allocate a
String for the caller that needs to be freed once it is no longer needed.
This was not done in the current implementation and thus this was causing
a memory leak.
This commit fixes this by explicitly
freeing the resources after usage.Fixes #4910
Ref: https://www.alsa-project.org/alsa-doc/alsa-lib/group___control.html#ga547dcead4a72f24db4a0f9f530f75228