CHANGE(server): Allow spaces in username by default #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A username will now always be trimmed before it gets assigned to a user. That means that names with leading and/or trailing whitespace are now no longer possible.
When checking whether a given username is valid, it being trimmed is now also a criterion. All names with leading and/or trailing whitespace will be considered invalid from now on.
The default RegEx for describing valid usernames was updated to also allow for spaces in names. Note that "empty" names (e.g. names only consisting of whitespace) are not possible since usernames are always trimmed before being applied and the RegEx does not allow for names of length 0. Fixes mumble-voip#1202
davidebeatrici
approved these changes
Apr 11, 2021
Kissaki
reviewed
Apr 12, 2021
Kissaki
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commits in this PR deal with making sure that usernames
will only be used in a trimmed version, so that the allowance of spaces
in usernames will not allow for "empty" (pure whitespace) names.
Fixes #1202
Checks