Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE(server): Allow spaces in username by default #4925



Copy link

@Krzmbrzl Krzmbrzl commented Apr 11, 2021

The first commits in this PR deal with making sure that usernames
will only be used in a trimmed version, so that the allowance of spaces
in usernames will not allow for "empty" (pure whitespace) names.

Fixes #1202


A username will now always be trimmed before it gets assigned to a user.
That means that names with leading and/or trailing whitespace are now no
longer possible.
When checking whether a given username is valid, it being trimmed is now
also a criterion. All names with leading and/or trailing whitespace will
be considered invalid from now on.
The default RegEx for describing valid usernames was updated to also
allow for spaces in names.

Note that "empty" names (e.g. names only consisting of whitespace) are
not possible since usernames are always trimmed before being applied and
the RegEx does not allow for names of length 0.

Fixes mumble-voip#1202
@Krzmbrzl Krzmbrzl merged commit 6fee79b into mumble-voip:master Apr 13, 2021
@Krzmbrzl Krzmbrzl deleted the change-allow-spaces-in-usernames branch April 13, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Allow at least the space character in the default username variable
3 participants