FIX(client): CrashReporter considering 2xx codes as errors #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently nobody has told Qt that 2xx HTTP status codes are considered success. Therefore checking QNetworkReply::error() in order to check whether the transfer was successful, does not work. Instead this commit makes sure that the raw HTTP status code is checked instead and if it is in range [200,299], the sending of the report is considered a success. Furthermore this commit reworks the Strings displayed to the user (message box) as these were excessively long. These formulations have been replaced with (hopefully) more concise versions. Fixes mumble-voip#4928
Krzmbrzl
force-pushed
the
fix-crash-reporter-success-check
branch
from
e95d3b3
to
affc426
Compare
davidebeatrici
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently nobody has told Qt that 2xx HTTP status codes are considered
success. Therefore checking QNetworkReply::error() in order to check
whether the transfer was successful, does not work.
Instead this commit makes sure that the raw HTTP status code is checked
instead and if it is in range [200,299], the sending of the report is
considered a success.
Furthermore this commit reworks the Strings displayed to the user as
these were excessively long. These formulations have been replaced with
(hopefully) more concise versions.
Fixes #4928
Checks