FIX/FEAT(client): Improvements for using --multiple #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"--config" is parsed before the main argument parsing loop. Then these arguments are captured a second time in the else clause and shoved into the "url" variable. Having a valid url (the path to a config is a valid file URL) causes the app to post an OpenURLEvent. This is pretty harmless, it just causes the settings to load again. But the bigger problem is that Global::get().mw->on_qaServerConnect_triggered(true) is not called. So, even if you have autoconnect enabled, launching mumble with "--multiple --config PATH" won't actually autoconnect. This commit fixes this by skipping over the "--config" arguments in the main parsing loop.
Krzmbrzl
force-pushed
the
feat-improve-multi-instance-usage
branch
from
de6f98e
to
d657d16
Compare
davidebeatrici
approved these changes
Apr 26, 2021
At startup, the settings for a Mumble instance are loaded (either using the default location or the "--config" file that was supplied). Then Mumble checks to see if a valid certificate was loaded. If it wasn't, it looks for a certificate in a hardcoded path (QStandardPaths::DocumentsLocation). If there is a certificate there, it uses it. If not, it creates a new cert and saves it to that hardcoded path. This all means that when you run a second instance for the first time, there will be no certificate in the supplied "--config", so it will use the certificate in the hardcoded path, which is almost certainly the certificate that the other mumble instance is using. Connecting to a server with this certificate will authenticate you as the user who has that certificate registered. This is probably not what you want. This commit fixes this issue by adding a CLI option that allows the user to specify the default certificate directory.
Krzmbrzl
force-pushed
the
feat-improve-multi-instance-usage
branch
from
d657d16
to
590bb2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See the individual commits for a detailed description of what has been changed.
Checks