FEAT(client): Search dialog #4967
Conversation
Krzmbrzl
added
client
ui
feature-request
Krzmbrzl
changed the title
|
This is a very good idea, I like it a lot! I think UI-wise it would be much better for the user to have them grouped in those two categories. |
|
Perhaps another good solution would be two rows:
I think especially the label for the first row would make it much clearer for the user what these do. I take it that the settings icon on the right unhides the options? Then it wouldn't be a problem space-wise to have two rows anyway. |
Yes indeed. Thanks for the feedback. I have implemented your second suggestion and I'll update the screenshot accordingly :) |
Instead of implicitly assuming that the root channel has ID 0, there is now an explicit constant (of the same value) that is used in all places instead of literal "0" when referring to the root channel's ID.
This setting will be needed for other purposes as well and therefore putting this into the TalkingUI group of settings in no longer applicable.
Before the channel tree (UserView) in the main UI had a "feature" called keyboard search. If the channel tree had focus and the user started typing on their keyboard, Mumble would search for an entry in the tree (either channel or user) that matches the invisibly typed search String. This is however very impractical for searching as it is unclear if and when this will expand collapsed entries or how subsequent searches work. It is not even clear when the current search has ended and thus typing another letter will start a new one. And for users who don't expect such an invisible feature, this is a bad experience as their channel tree selection jumps around wildly if they accidentally push a key. The search functionality will be provided by a more robust implementation in a following commit.
The shortcut for toggling channel filters was Ctrl+F. While this makes sense semantically, this specific shortcut is associated with starting a search in 99% of all applications out there. Thus using it for something else does not make for a very smooth user experience. The new shortcut for filtering is thus set to be Alt+F instead.
This commit introduces a fully featured search dialog. Note that selections in the search dialog are synchronized with the main UI and thus "whisper to selection" works by selecting something in the search dialog as well. There are also default actions that are executed when a search result is activated (double-clicked or pressing enter on it). What that action is exactly, can be configured in the settings. Furthermore the context menu works as expected when invoked on entries in the search result list. In order to disambiguate the results, the full channel hierarchy to the search result's parent channel is shown below each result. The search dialog can be toggled via Ctrl+F when Mumble has focus or by using the new entry in the toolbar. Additionally there is a new global shortcut that can be configured for this purpose. Note however that on Windows the search dialog won't obtain focus when toggled in a situation when Mumble does not have focus already.
|
there is a string on weblate: you mean |
|
@deluxghost There should be both. Once for clients and once for channels |
|
Ah no. I see what you mean. Yeah that's an error. Thanks for pointing this out 👍 |
|
See #4985 |
This PR introduces a fully featured search dialog.
Note that selections in the search dialog are synchronized with the main
UI and thus "whisper to selection" works by selecting something in the
search dialog as well.
There are also default actions that are executed when a search result is
activated (double-clicked or pressing enter on it). What that action is
exactly, can be configured in the settings.
Furthermore the context menu works as expected when invoked on entries
in the search result list.
In order to disambiguate the results, the full channel hierarchy to the
search result's parent channel is shown below each result.
The search dialog can be toggled via Ctrl+F when Mumble has focus or by
using the new entry in the toolbar. Additionally there is a new global
shortcut that can be configured for this purpose. Note however that on
Windows the SearchDialog won't obtain focus when toggled in a situation
when Mumble does not have focus already.
Checks
Note: The previous "search as you type" functionality got replaced by this new functionality and is therefore no longer available