FEAT(client): Removed classic theme #4969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having to maintain the old legacy theme of Mumble was becoming a burden as new icons would have to be created two times in order to fit both theme variants. That never happened and thus the new icons looked very out-of-place in the Classic theme. Besides the classic theme was also missing several icons altogether already. Thus it has been concluded to remove the Classic theme.
Krzmbrzl
force-pushed
the
remove-classic-theme
branch
from
89a1e54
to
7d76f0e
Compare
davidebeatrici
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to maintain the old legacy theme of Mumble was becoming a burden
as new icons would have to be created two times in order to fit both
theme variants. That never happened and thus the new icons looked very
out-of-place in the Classic theme. Besides the classic theme was also
missing several icons altogether already.
Thus it has been concluded to remove the Classic theme.
Furthermore this PR adds some aliases that were missing in both themes which fixes #4937
Checks