FIX(client): Properly show currently selected audio device in settings dialog #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
force-pushed
the
settings-show-current-audio-device-properly
branch
from
dda381d
to
a761ba1
Compare
This comment has been minimized.
This comment has been minimized.
|
Works for me with the ALSA Backend. 👍 |
Krzmbrzl
requested changes
May 9, 2021
There was a problem hiding this comment.
- Imo
autois used way too often in this PR as in many places it completely hides the type of variables. This is an important information that I want to see immediately when reading through the code.
Using this for iterators is fine and also using it for the result of casts or as a loop variable in a ranged for. Using it for storing the value of a function is not appropriate (imo). - The functions should be marked with the
overridekeyword. Potentially this makes it necessary to prepend a REFAC commit that marks other functions withoverridealready.
davidebeatrici
force-pushed
the
settings-show-current-audio-device-properly
branch
from
a761ba1
to
e9a5f12
Compare
Let's do it in a dedicated pull request, because I would also like to replace all For reference: qt/qtspeech@aa24a10 |
Krzmbrzl
requested changes
May 10, 2021
| @@ -138,6 +138,7 @@ class AudioInputRegistrar { | |||
| AudioInputRegistrar(const QString &n, int priority = 0); | |||
| virtual ~AudioInputRegistrar(); | |||
| virtual AudioInput *create() = 0; | |||
| virtual const QVariant getDeviceChoice() = 0; | |||
There was a problem hiding this comment.
We return QVariant by value, so why do we make it const?
There was a problem hiding this comment.
For consistency with getDeviceChoices(), which returns a const list.
There was a problem hiding this comment.
That also returns by value, right? In that case that doesn't seem to make too much sense either 👀
| @@ -65,6 +65,7 @@ class AudioOutputRegistrar { | |||
| AudioOutputRegistrar(const QString &n, int priority = 0); | |||
| virtual ~AudioOutputRegistrar(); | |||
| virtual AudioOutput *create() = 0; | |||
| virtual const QVariant getDeviceChoice() = 0; | |||
…s dialog Every audio backend implementation was moving the current device at the top. This commit replaces that logic by selecting the current device in the combobox.
davidebeatrici
force-pushed
the
settings-show-current-audio-device-properly
branch
from
e9a5f12
to
4627a83
Compare
Krzmbrzl
approved these changes
May 10, 2021
|
I honestly would leave it as it is, we don't have to change the returned variable's value anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every audio backend implementation was moving the current device at the top.
This commit replaces that logic by selecting the current device in the combobox.
Before
After