FEAT(client): Introduce Positional Audio Viewer, replacement for MumblePAHelper #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hate that |
Krzmbrzl
requested changes
Jun 16, 2021
davidebeatrici
force-pushed
the
positional-audio-viewer
branch
from
7e47c86 to
8dcf12e
Compare
Krzmbrzl
requested changes
Jun 17, 2021
davidebeatrici
force-pushed
the
positional-audio-viewer
branch
from
8dcf12e to
db96322
Compare
Krzmbrzl
reviewed
Jun 21, 2021
…lePAHelper MumblePAHelper (Mumble Positional Audio Helper) is the tool we had been using to test positional audio plugins. As the application is basically just a dialog, we thought many times in the past about merging it in Mumble. Now that MumblePAHelper is obsolete (it doesn't support the new API), it's the perfect time to do that. The dialog can be opened through a new action in the "Developer" menu. Showcase: https://odysee.com/positional-audio-viewer-left4dead:f4ad40f7e55797e6c8d2b1817915cab71b4893f4
davidebeatrici
force-pushed
the
positional-audio-viewer
branch
from
db96322 to
0a2c555
Compare
Krzmbrzl
approved these changes
Jun 23, 2021
|
@davidebeatrici |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MumblePAHelper (Mumble Positional Audio Helper) is the tool we had been using to test positional audio plugins.
As the application is basically just a dialog, we thought many times in the past about merging it in Mumble.
Now that MumblePAHelper is obsolete (it doesn't support the new API), it's the perfect time to do that.
The dialog can be opened through a new action in the "Developer" menu.
Showcase: https://odysee.com/positional-audio-viewer-left4dead:f4ad40f7e55797e6c8d2b1817915cab71b4893f4