-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT(client): Add warning when using positonal audio on mono output #5247
FEAT(client): Add warning when using positonal audio on mono output #5247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should run clang-format
on the source tree in order to bring your code changes into the same format as the rest of the codebase.
After you have integrated the formatting changes into your commit (amend the changes), you should also run scripts/updatetranslations.py
in order to bring the translation files up to date.
I have added the suggested changes. |
Why are there 2 translation commits? Also please squash the code-review changes into your original commit. And it seems that you did not run clang-format as requested 👀 |
@kartikkhullar what's the status on this? |
I don't have access to my computer from last few days, most probably will get back to you by Monday. |
I have squashed all the changes into original commit. Also, I did ran clang-format as requested. I tried running it again but it says "no modified files to format". So I guess it did ran successfully previously. |
That is not what I wanted. We need to have all code changes in one commit and then all translation changes in another, separate commit. And also there should be no merge commit in your branch. I recommend the following steps:
|
67bcebe
to
19bcdbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of tidying your commit history for you
df9208a
to
2ab5818
Compare
As requested in mumble-voip#5238 this commit adds a warning message in the chat when positional audio is enabled on mono output device. Fixes mumble-voip#5238
2ab5818
to
70082df
Compare
Merge request mumble-voip#5247 introduced a warning that is triggered when Mumble is configured to use positional audio, if only a single channel output is configured. However, this warning is emitted from the audio thread and therefore causes a crash. This is because Qt does not want to add child QObjects from any other thread than main. This commit makes sure the static version of ``logOrDefer`` is called and also adds a check to ``Log::log`` to forward the call to the main thread, if necessary. Fixes mumble-voip#6507
Merge request mumble-voip#5247 introduced a warning that is triggered when Mumble is configured to use positional audio and only a single channel output is configured. However, this warning is emitted from the audio thread and therefore causes a crash. This is because Qt does not want to add child QObjects from any other thread than main. This commit makes sure the static version of ``logOrDefer`` is called and also adds a check to ``Log::log`` to forward the call to the main thread, if necessary. Fixes mumble-voip#6507
Merge request mumble-voip#5247 introduced a warning that is triggered when Mumble is configured to use positional audio and only a single channel output is configured. However, this warning is emitted from the audio thread and therefore causes a crash. This is because Qt does not want to add child QObjects from any other thread than main. This commit makes sure the static version of ``logOrDefer`` is called and also adds a check to ``Log::log`` to forward the call to the main thread, if necessary. Fixes mumble-voip#6507
Merge request #5247 introduced a warning that is triggered when Mumble is configured to use positional audio and only a single channel output is configured. However, this warning is emitted from the audio thread and therefore causes a crash. This is because Qt does not want to add child QObjects from any other thread than main. This commit makes sure the static version of ``logOrDefer`` is called and also adds a check to ``Log::log`` to forward the call to the main thread, if necessary. Fixes #6507 (cherry picked from commit 6374856)
Merge request #5247 introduced a warning that is triggered when Mumble is configured to use positional audio and only a single channel output is configured. However, this warning is emitted from the audio thread and therefore causes a crash. This is because Qt does not want to add child QObjects from any other thread than main. This commit makes sure the static version of ``logOrDefer`` is called and also adds a check to ``Log::log`` to forward the call to the main thread, if necessary. Fixes #6507 (cherry picked from commit 6374856)
As requested in #5238 this commit adds a warning message in the chat when positional audio is enabled on mono output device.
Implements #5238
Checks