FEAT(client): Add opus as output format for recording

[evris99]

This commits adds opus as an output format for voice recordings as requested in #5065. It uses an OGG container like the already implemented Vorbis codec but has much better compression. For clarity the .opus file extension is used.

Implements #5065

Checks

• My commits follow the commit guidelines

[Krzmbrzl]

Changes LGTM now but we will have to figure out why this doesn't work on Linux. Maybe we'll have to introduce an option for this that is OFF by default on Linux 🤔
But before doing that I would like to find out why it seems that the Linux version of libsndfile seems to ship without Opus support.

[evris99]

I see that the support for opus files was added in libsndfile version 1.0.29 from here. But Ubuntu versions less than 21.04 use a previous version of the library (source).

[Krzmbrzl]

Ah yes that could explain it.

It seems that Ubuntu 20.04 ships version 1.0.28. The cmake output agrees with this observation.

Because of this I would suggest to following: Check whether the libsndfile version is >= 1.0.29 here:

mumble/src/mumble/CMakeLists.txt

Lines 452 to 463 in 207dbe0

	find_pkg("SndFile;LibSndFile;sndfile" REQUIRED)
	# Look for various targets as they are named differently on different platforms
	if(static AND TARGET sndfile-static)
	target_link_libraries(mumble PRIVATE sndfile-static)
	elseif(TARGET SndFile::sndfile)
	target_link_libraries(mumble PRIVATE SndFile::sndfile)
	elseif(TARGET sndfile)
	target_link_libraries(mumble PRIVATE sndfile)
	else()
	target_link_libraries(mumble PRIVATE ${sndfile_LIBRARIES})
	endif()

I assume that the found version is written to SndFile_VERSION so you should be able to use that to check for the version.

If the version is >= 1.0.29, then add a global macro definition USE_SNDFILE_OPUS and then encapsulate all of your changes with #ifdef USE_SNDFILE_OPUS blocks.

That should include this feature if the used sndfile-library is recent enough to support it.

[evris99]

Any ideas as to why the macOS workflows fail?

[Krzmbrzl]

Any ideas as to why the macOS workflows fail?

Because macOS is weird? 😅

Don't worry though - it just does this sometimes (we don't know why or when). It should be unrelated to your changes though. The important bit (building) succeeded.

[Krzmbrzl]

Okay the changes LGTM now 👍

Please squash all of your commits into the first one and once that is done, please run scripts/updatetranslations.py in order to bring the translation files up-to-date.
This will create a new, separate commit.

Then force-push your branch with these two new commits.

[Krzmbrzl]

It seems like in your first commit the description of what was done went missing. Please use the same description for the commit as you did for this PR (including the Fixes xxx line) :)

[Krzmbrzl]

Thank you very much for your contribution 👍

[evris99]

Thank you for your help