FEAT(server): Add option to disallow recording #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the used audio output system was bogus and therefore configured to use a 0Hz sample rate, starting a recording would crash Mumble due to an assertion in the VoiceRecorder class. This commit adds a check for this situation and instead of crashing Mumble, this will log a warning message to the console and close the VoiceRecorderDialog instead.
Krzmbrzl
added
client
server
feature-request
|
Typo in commit and PR title |
Krzmbrzl
changed the title
Krzmbrzl
force-pushed
the
feat-disallow-recording
branch
from
8847c77 to
3ebbd4e
Compare
|
Fixed, thanks! |
This commit adds a new server-configuration that can be used in the murmur.ini file. It can be used to forbid anyone on the server from using Mumble's built-in recording functionality. Any client trying to start a recording nonetheless, will be kicked from the server. From Mumble 1.5.0 clients will know about this configuration and will disable the recording action in the UI, if recording is not allowed on the server.
The recording button is now disabled by default. It gets enabled only when connected to a server (that allows recording). This is done because the recording feature can't be used without a server connection anyway (doing so will result in an error popup). Thus this restriction is now reflected in the UI as well.
Krzmbrzl
force-pushed
the
feat-disallow-recording
branch
from
3ebbd4e to
bbbd433
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new server-configuration that can be used in the
murmur.ini file. It can be used to forbid anyone on the server from
using Mumble's built-in recording functionality.
Any client trying to start a recording nonetheless, will be kicked from
the server.
From Mumble 1.5.0 clients will know about this configuration and will
disable the recording action in the UI, if recording is not allowed on
the server.
Additionally this PR also fixes/revamps two other small issues related to the recording feature. See the respective commit messages or details.
Checks