CHANGE: Make joining root channel explicit #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
changed the title
When joining a server, a client is placed in the root channel by default. However, this placement was implicit as the server would explicitly exclude this information to be broadcast with the sent UserState message. In order to facilitate external applications to get this all right, this commit now makes sure that this information is shared explicitly (just as if the user would be placed in a different channel because the server remembered their last channel). Note: This commit also adapts the client code to only move the user if the specified channel is not its current channel already, but even without this change, the client code will handle the additional information gracefully. Fixes mumble-voip#5270
Krzmbrzl
force-pushed
the
change-make-joining-root-channel-explicit
branch
from
0d71731
to
bdbc6d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When joining a server, a client is placed in the root channel by
default. However, this placement was implicit as the server would
explicitly exclude this information to be broadcast with the sent
UserState message.
In order to facilitate external applications to get this all right, this
commit now makes sure that this information is shared explicitly (just
as if the user would be placed in a different channel because the server
remembered their last channel).
Note: This commit also adapts the client code to only move the user if
the specified channel is not its current channel already, but even
without this change, the client code will handle the additional
information gracefully.
Fixes #5270
Checks