CHANGE(ui): Make lock icons fit with other icons #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current channel lock icons introduced for 1.4.x use a line-art style. This stands out against the other icons that show in the channel tree (user mute status, comments, friend hearts, etc.) because they are all filled in. The included changes to the icons are: - Switch to a filled-in style - Set opacity to 75% to match other icons - Slightly shrink them, as they look somewhat large compared to the channel comment icon.
|
Could you provide a screenshot of your changes? |
|
Light theme: Dark theme: |
Krzmbrzl
approved these changes
Jan 18, 2022
|
Thanks for these changes as well 👍 |
|
Turns out this can't be easily backported without adding it to the old mumble-theme repository. However, I don't think that it is worth going down that route. Thus, this will simply be shipped once we release 1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current channel lock icons introduced for 1.4.x use a line-art
style. This stands out against the other icons that show in the
channel tree (user mute status, comments, friend hearts, etc.) because
they are all filled in.
The included changes to the icons are:
channel comment icon.
Checks