-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT(client): Add shortcut to send plain text messages #5744
Conversation
47ea8ae
to
82907a0
Compare
This might be outside of the scope of this feature, but when sending a message with multiple simultaneous spaces, the multiple spaces are rendered as one space, regardless of whether the existing Markdown path is taken or this new 'plain text' one. This happens because the log is a QTextDocument and renders the string as HTML. Is that something that should be tackled? |
Yes I think it should be tackled. After all I think that a user would expect a plain-text message to really be sent as-is - including all spaces. I think the issue would be easily solved by replacing all spaces by non-breakable spaces. We'd have to check though if that can somehow mess with line breaking/wrapping |
Yeah, I think that's good enough ^^ |
Add the ability to press Ctrl+Enter to send a plain text message while preserving line breaks. This adds an easy way of preserving messages with line breaks without having to resort to using Markdown. Implements mumble-voip#5707
82907a0
to
e658c4a
Compare
Thank you very much for this contribution 👍 |
Add the ability to press Ctrl+Enter to send a plain text message while
preserving line breaks. This adds an easy way of preserving messages
with line breaks without having to resort to using Markdown.
Implements #5707
Checks