FIX(server): Don't silently ignore errors in INI #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory these changes should cause the server to no longer silently ignore encountered INI syntax errors. In practice however, it seems that it is pretty much impossible to create an INI file that Qt actually considers erroneous and thus this code essentially doesn't work. But in case Qt ever fixes this weird behavior, at least in theory Mumble users should immediately profit from it. Fixes mumble-voip#5749
davidebeatrici
approved these changes
Jul 20, 2022
|
Krzmbrzl:fix-ini-errros-ignored |
|
Why are you commenting the name of the feature branch of this PR? |
|
Krzmbrzl:fix-ini-errros-ignored |
|
@LocoabordoR8 if you continue this nonsense I'll have to block you from our organization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory these changes should cause the server to no longer silently
ignore encountered INI syntax errors.
In practice however, it seems that it is pretty much impossible to
create an INI file that Qt actually considers erroneous and thus this
code essentially doesn't work. But in case Qt ever fixes this weird
behavior, at least in theory Mumble users should immediately profit from
it.
Fixes #5749
Checks