FEAT(client): Add User and Listener volume slider to context menus #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hartmnt
force-pushed
the
feat_menu_slider
branch
3 times, most recently
from
c20cc82 to
952f660
Compare
Krzmbrzl
reviewed
Aug 10, 2022
Krzmbrzl
added
client
ui
feature-request
Hartmnt
force-pushed
the
feat_menu_slider
branch
23 times, most recently
from
0098e1f to
17b40d0
Compare
Hartmnt
force-pushed
the
feat_menu_slider
branch
7 times, most recently
from
187c206 to
4af684b
Compare
Krzmbrzl
reviewed
Aug 16, 2022
Hartmnt
force-pushed
the
feat_menu_slider
branch
8 times, most recently
from
aef3979 to
cba41f6
Compare
As requested in mumble-voip#4748 this commit implements a volume control slider for User local volume and Listener local volume in the relevant context menus for easier reach and quicker adjustments. The VolumeSliderWidgetAction was implemented as a base class for UserLocalVolumeSlider and ListenerLocalVolumeSlider which were then added as QActions in the MainWindow to the context menus qmUser and qmListener respectively. The existing LocalVolumeDialogs for users and listeners have been removed. Additionally, the new generic MenuLabel class was created to be able to add non-interactive items into QMenus. Co-authored-by: Hartmnt <hartmunt@protonmail.com>
Hartmnt
force-pushed
the
feat_menu_slider
branch
from
cba41f6 to
1454393
Compare
Krzmbrzl
approved these changes
Aug 18, 2022
|
Thanks for working on this 👍 |
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this pull request
Jun 30, 2024
… certificate In mumble-voip#5776 the local volume adjustment sliders were moved into the user context menu. A log warning message appears, if you adjust the volume of a client without certificate. Due to a combination of Qt's buggy MouseWheel events and the oversight that volume changes to the DB happen much more frequently with that change, the log warning messages are spammed way to often now in that case. This commit moves the log warning message explicitly into a separate slot on slider release. Note: We "lose" the warning message for other input methods that are not "releasing the slider", but given the fact that certificates are pretty prevalent now and dragging the slider is likely the most often used input method, this will likely affect a very little amount of users. Fixes mumble-voip#6462
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this pull request
Jun 30, 2024
… certificate In mumble-voip#5776 the local volume adjustment sliders were moved into the user context menu. A log warning message appears, if you adjust the volume of a client without certificate. Due to a combination of Qt's buggy MouseWheel events and the oversight that volume changes to the DB happen much more frequently with that change, the log warning messages are spammed way to often now in that case. This commit moves the log warning message explicitly into a separate slot on slider release. Note: We "lose" the warning message for other input methods that are not "releasing the slider", but given the fact that certificates are pretty prevalent now and dragging the slider is likely the most often used input method, this will likely affect a very little amount of users. Fixes mumble-voip#6462
Hartmnt
added a commit
to Hartmnt/mumble
that referenced
this pull request
Jul 1, 2024
… certificate In mumble-voip#5776 the local volume adjustment sliders were moved into the user context menu. A log warning message appears, if you adjust the volume of a client without certificate. Due to a combination of Qt's buggy MouseWheel events and the oversight that volume changes to the DB happen much more frequently with that change, the log warning messages are spammed way to often now in that case. This commit moves the log warning message explicitly into a separate slot on slider release. Note: We "lose" the warning message for other input methods that are not "releasing the slider", but given the fact that certificates are pretty prevalent now and dragging the slider is likely the most often used input method, this will likely affect a very little amount of users. Fixes mumble-voip#6462
Krzmbrzl
pushed a commit
that referenced
this pull request
Jul 1, 2024
… certificate In #5776 the local volume adjustment sliders were moved into the user context menu. A log warning message appears, if you adjust the volume of a client without certificate. Due to a combination of Qt's buggy MouseWheel events and the oversight that volume changes to the DB happen much more frequently with that change, the log warning messages are spammed way to often now in that case. This commit moves the log warning message explicitly into a separate slot on slider release. Note: We "lose" the warning message for other input methods that are not "releasing the slider", but given the fact that certificates are pretty prevalent now and dragging the slider is likely the most often used input method, this will likely affect a very little amount of users. Fixes #6462 (cherry picked from commit efe91b9)
Krzmbrzl
pushed a commit
that referenced
this pull request
Jul 6, 2024
… certificate In #5776 the local volume adjustment sliders were moved into the user context menu. A log warning message appears, if you adjust the volume of a client without certificate. Due to a combination of Qt's buggy MouseWheel events and the oversight that volume changes to the DB happen much more frequently with that change, the log warning messages are spammed way to often now in that case. This commit moves the log warning message explicitly into a separate slot on slider release. Note: We "lose" the warning message for other input methods that are not "releasing the slider", but given the fact that certificates are pretty prevalent now and dragging the slider is likely the most often used input method, this will likely affect a very little amount of users. Fixes #6462 (cherry picked from commit efe91b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4748
This commit is a continuation of the work of @fgilcc in #4792
It adds a slider for user/listener volume adjustment directly into the context menu. This is similar to how other voice application do it and saves a few clicks.
TODO:
Make entire thingy selectable and open the Dialog on clickFix right side padding