FIX/FEAT(client, ui): Minimal view improvements #5777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When activating minimal view, sometimes it would work as expected, hiding all UI elements but the channel tree, but other times various other elements would remain visible until opening and applying the settings. The reason for this was that inside the updateView function, we called restoreGeometry after we have set the visibility of the respective UI elements, which could undo our previous visibility changes, leaving these elements visible. By applying the visibility changes after the geometry restoration, we avoid this problem.
Krzmbrzl
added
client
ui
feature-request
When not connected to a server, the minimal view will not display any UI elements, which can be confusing (especially since the minimal view state is saved and restored on restart). In order to let users know what is going on and how to make the UI elements re-appear, this commit adds a new note to the UI in these cases. Fixes mumble-voip#5495
Krzmbrzl
force-pushed
the
improve-minimal-view
branch
from
a92fb5e to
2336578
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for what changed.
Fixes #5495
Checks