FEAT(server): Flag bot connections, so user count does not get inflated by them #5948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
requested changes
Nov 13, 2022
This commit introduces a new flag that connecting clients can use to tell the server they are connecting to that they consider themselves bot clients. This information can then be used (as is the case for the official server implementation) to e.g. correct the reported user count on the server to only include "real" clients - aka: no bots. Fixes mumble-voip#5461
Krzmbrzl
approved these changes
Nov 27, 2022
|
Thank you for implementing this 👍 |
|
You are awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended Authenticate message by int
client_typeinMumble.protoso server knows what type of connection it is(for now it's just 0 forREGULARand 1 forBOT). Next I created header file calledClientType.hwhere I define enum class for types of connections. This enum is easily extendable for any special connection types in future.In
Server.hI extended Server class bym_botCountattribute.In
Messages.cppI extendedmsgAuthenticatefunction by a check at the end before authentication log that checks whether connection type is regular or bot and if it's a bot then it incrementsm_botCountby one. It also setsclient_typeforServerUser.Before disconnect in
Server.cppI check ifServerUserisBOTand if yes I decrementm_botCountby one. In the final user count,m_botCountgets subtracted from the user count to show real user count.Implements #5461
Checks