Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor: replace CStr::from_ptr(ptr).to_str() with from_utf8_unchecked #66
@@ Coverage Diff @@ ## master #66 +/- ## ========================================== - Coverage 72.09% 72.09% -0.01% ========================================== Files 109 109 Lines 7279 7278 -1 ========================================== - Hits 5248 5247 -1 Misses 2031 2031
Wodann left a comment
Thank you for you PR. Good find to reuse the
I added one request for change, as we only need to replace the UTF-8 validation in the ABI. If you could revert the changes to
There is one other thing that needs to happen before we can merge this PR. Issue #53 depends on issue #52. That issue adds unit tests to validate that our compiler always generates valid UTF-8 strings. Once that issue has been closed, we can guarantee that there will not be any runtime regressions. If you have time, would you be interested in having a look at issue #52 as well? It will introduce you to an important development aspect of Mun; namely regression testing.