Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to check if compiler output strings is valid utf8 #67

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@legendiguess
Copy link
Contributor

legendiguess commented Dec 22, 2019

closes #52

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #67 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   72.09%   72.14%   +0.04%     
==========================================
  Files         109      109              
  Lines        7279     7291      +12     
==========================================
+ Hits         5248     5260      +12     
  Misses       2031     2031
Impacted Files Coverage Δ
crates/mun_runtime/src/test.rs 96.35% <100%> (+0.35%) ⬆️
crates/mun_target/src/spec/windows_msvc_base.rs 100% <0%> (ø) ⬆️
...ates/mun_target/src/spec/x86_64_pc_windows_msvc.rs 100% <0%> (ø) ⬆️
crates/mun_codegen/src/code_gen/linker.rs 35.63% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6896708...9cec921. Read the comment docs.

@legendiguess legendiguess marked this pull request as ready for review Dec 23, 2019
Copy link
Collaborator

Wodann left a comment

Nice job on the pull request. This is precisely the set-up that we were looking for :)

crates/mun_runtime/src/test.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/test.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

Wodann left a comment

Nice. Now the unit test is much more minimalistic :)

There is still one typo left. Can you fix that? Once that's done, I'll merge both of your pull requests 👍

crates/mun_runtime/src/test.rs Outdated Show resolved Hide resolved
@Wodann
Wodann approved these changes Dec 24, 2019
@Wodann Wodann merged commit 6be21e3 into mun-lang:master Jan 3, 2020
15 checks passed
15 checks passed
Check
Details
Test (ubuntu-latest, stable)
Details
Test (ubuntu-latest, beta)
Details
Test (ubuntu-latest, nightly)
Details
Test (windows-2016, stable)
Details
Test (macOS-latest, stable)
Details
Check Style Check Style
Details
grcov (ubuntu-latest)
Details
grcov (macOS-latest) grcov (macOS-latest)
Details
grcov (windows-2016)
Details
Artifacts (ubuntu-latest, linux64, mun libmun_runtime.so)
Details
Artifacts (windows-2016, win64, mun.exe mun_runtime.dll mun_runtime.dll.lib)
Details
Artifacts (macOS-latest, osx64, mun libmun_runtime.dylib)
Details
codecov/patch 100% of diff hit (target 72.09%)
Details
codecov/project 72.14% (+0.04%) compared to 6896708
Details
@baszalmstra

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.