Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better error message printing when signature is missing #80

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@baszalmstra
Copy link
Collaborator

baszalmstra commented Jan 12, 2020

Adds impl fmt::Display in the ABI autogen to get more correct descriptive error messages

@baszalmstra baszalmstra requested a review from Wodann Jan 12, 2020
@baszalmstra baszalmstra self-assigned this Jan 12, 2020
@Wodann
Wodann approved these changes Jan 12, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #80 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #80      +/-   ##
=========================================
- Coverage   74.75%   74.6%   -0.15%     
=========================================
  Files         117     117              
  Lines        8868    8885      +17     
=========================================
  Hits         6629    6629              
- Misses       2239    2256      +17
Impacted Files Coverage Δ
crates/mun_abi/src/autogen_impl.rs 94.28% <0%> (-4.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267f3c3...3d1c834. Read the comment docs.

@baszalmstra baszalmstra merged commit 473f480 into mun-lang:master Jan 12, 2020
13 of 15 checks passed
13 of 15 checks passed
Check
Details
Test (ubuntu-latest, stable)
Details
Test (ubuntu-latest, beta)
Details
Test (ubuntu-latest, nightly)
Details
Test (windows-2016, stable)
Details
Test (macOS-latest, stable)
Details
Check Style Check Style
Details
grcov (ubuntu-latest)
Details
grcov (macOS-latest) grcov (macOS-latest)
Details
grcov (windows-2016)
Details
Artifacts (ubuntu-latest, linux64, mun libmun_runtime.so)
Details
Artifacts (windows-2016, win64, mun.exe mun_runtime.dll mun_runtime.dll.lib)
Details
Artifacts (macOS-latest, osx64, mun libmun_runtime.dylib)
Details
codecov/patch 0% of diff hit (target 74.75%)
Details
codecov/project 74.6% (-0.15%) compared to 267f3c3
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.