Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: struct initialization fix for non constants #81

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@baszalmstra
Copy link
Collaborator

baszalmstra commented Jan 13, 2020

Fixes an issue when initializing structs with non constant values resulted in a crash.

@baszalmstra baszalmstra force-pushed the baszalmstra:fix/struct_init branch from 14e7be6 to f3d7a76 Jan 13, 2020
@baszalmstra baszalmstra requested a review from Wodann Jan 13, 2020
@baszalmstra baszalmstra self-assigned this Jan 13, 2020
@Wodann
Wodann approved these changes Jan 13, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #81 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage    74.6%   74.63%   +0.02%     
==========================================
  Files         117      117              
  Lines        8885     8893       +8     
==========================================
+ Hits         6629     6637       +8     
  Misses       2256     2256
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/adt.rs 100% <ø> (ø) ⬆️
crates/mun_codegen/src/ir/body.rs 90.2% <100%> (+0.11%) ⬆️
crates/mun_runtime/src/test.rs 96.89% <100%> (+0.07%) ⬆️
crates/mun_codegen/src/test.rs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473f480...f3d7a76. Read the comment docs.

@Wodann Wodann merged commit a204e63 into mun-lang:master Jan 13, 2020
15 checks passed
15 checks passed
Check
Details
Test (ubuntu-latest, stable)
Details
Test (ubuntu-latest, beta)
Details
Test (ubuntu-latest, nightly)
Details
Test (windows-2016, stable)
Details
Test (macOS-latest, stable)
Details
Check Style Check Style
Details
grcov (ubuntu-latest)
Details
grcov (macOS-latest) grcov (macOS-latest)
Details
grcov (windows-2016)
Details
Artifacts (ubuntu-latest, linux64, mun libmun_runtime.so)
Details
Artifacts (windows-2016, win64, mun.exe mun_runtime.dll mun_runtime.dll.lib)
Details
Artifacts (macOS-latest, osx64, mun libmun_runtime.dylib)
Details
codecov/patch 100% of diff hit (target 74.6%)
Details
codecov/project 74.63% (+0.02%) compared to 473f480
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.