Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change warning in dw_data_to_chart to stop #47

Closed
munichrocker opened this issue Jul 29, 2020 · 2 comments
Closed

Change warning in dw_data_to_chart to stop #47

munichrocker opened this issue Jul 29, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@munichrocker
Copy link
Owner

Should be an complete error, as the main point of running this function is to upload data. If it doesn't do that, the script is probably missing a vital part of it's purpose.

A warning is just displayed but does not stop the script, as I would expect it from an error that large.

So I'm thinking about changing the line 64 in dw_data_to_chart:
warning(paste0("There has been an error in the upload process. Statuscode of the response: ", httr::status_code(r)), immediate. = TRUE)
to:
stop(paste0("There has been an error in the upload process. Statuscode of the response: ", httr::status_code(r)), call. = TRUE)

@munichrocker munichrocker added enhancement New feature or request help wanted Extra attention is needed labels Jul 29, 2020
@munichrocker munichrocker self-assigned this Jul 29, 2020
@munichrocker
Copy link
Owner Author

Same question for dw_publish_chart, dw_edit_chart, dw_create_folder

@munichrocker munichrocker added this to the V1.2 milestone Jul 29, 2020
@munichrocker
Copy link
Owner Author

Included in ac78d2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant