plugins/virtualization/vserver/vserver_jiffies: several enhancements (but zsh) #648

Merged
merged 2 commits into from Oct 20, 2016

Projects

None yet

3 participants

@akorn
Contributor
akorn commented Sep 20, 2015
  • Switch to zsh (used to be bash)
  • Fix to remove dots from vserver names (replace them with underscores; dots confuse munin)
  • Drop support for old (pre 2.6.19) kernels
  • Replace cat | grep | cut pipelines with a single sed each
  • Add env.stripdomain (a domain name to strip from the end of vserver names when generating labels; be sure to include the leading dot)
@akorn akorn * Switch to zsh (used to be bash)
 * Fix to remove dots from vserver names (replace them with underscores;
   dots confuse munin)
 * Drop support for old (pre 2.6.19) kernels
 * Replace cat | grep | cut pipelines with a single sed each
 * Add env.stripdomain (a domain name to strip from the end of vserver names
   when generating labels; be sure to include the leading dot)
c9e77c3
@ssm
Member
ssm commented Sep 25, 2015

Since this is the first zsh plugin, the test suite also needs updating to test it before we can merge this.

@akorn
Contributor
akorn commented Sep 25, 2015

I might be willing to do that because I may write additional plugins in zsh later; do you have some pointers? I don't even know how/where to begin.

@ssm
Member
ssm commented Sep 25, 2015

Two pointers:

1: figure out how to syntax check a zsh script

2: add an "if interpreter is zsh" section in https://github.com/munin-monitoring/contrib/blob/master/t/test.t (copy from one of the other sections with just one test)

@akorn
Contributor
akorn commented Sep 25, 2015

OK, thanks; in case anyone else wants to do it, "zsh -n" works for syntax checking.
I certainly won't get around to this today, alas.

@akorn
Contributor
akorn commented Sep 26, 2015

Looks like the CI test is failing because the CI system doesn't have zsh installed.

@sumpfralle sumpfralle merged commit 78dea36 into munin-monitoring:master Oct 20, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment