DetectX Module #916
DetectX Module #916
Conversation
Added Status to client data (Clean/Infected) which is searchable
Tab for DetectX module uses the listing headers. Fixed lacking localization for widget. Added FA icon to Widget to match the style Removed old outdated fr.json locale.
|
|
||
| # detectx controller | ||
| #CTL="${BASEURL}index.php?/module/detectx/" | ||
| # Set preference to include this file in the preflight check |
bochoven
Dec 14, 2017
Contributor
Please also drop an empty json so the client does not complain about the file not found
Please also drop an empty json so the client does not complain about the file not found
|
Thanks. Could you please fix the indenting? I have a hard time reading the code.. ;-D |
|
Atom must be messing with it since I turned off softwraps. I'll get it all prettified and a touch statement to add an empty json file in |
|
@bochoven Is that any better? |
| $this->deleteWhere('serial_number=?', $this->serial_number); | ||
|
|
||
| // Process json into object thingy | ||
| $data = json_decode($json, true); |
bochoven
Dec 15, 2017
Contributor
This block needs indenting
This block needs indenting
| "searchdate": "Search Date", | ||
| "status": "Status" | ||
| }, | ||
| "widget": { |
bochoven
Dec 15, 2017
Contributor
Please also indent the JSON
Please also indent the JSON
|
@bochoven should be fixed now. |
| <string>/Applications/DetectX Swift.app/Contents/MacOS/DetectX Swift</string> | ||
| <string>search</string> | ||
| <string>-aj</string> | ||
| <string>/usr/loca/munki/preflight.d/cache/detectx.json</string> |
bochoven
Dec 16, 2017
Contributor
Path is missing an 'l', should be /usr/local/munki/preflight.d/cache/detectx.json
Path is missing an 'l', should be /usr/local/munki/preflight.d/cache/detectx.json
| // | ||
| return array( | ||
| 'client_tabs' => array( | ||
| 'detectx-tab' => array('view' => 'detectx_tab', 'i18n' => 'detectx.clienttitle', 'badge' => 'detectx-cnt'), |
bochoven
Dec 16, 2017
Contributor
detectx.clienttitle does not exist in the locale.json. You may want to change that to detectx.title (this controls the name in the dropdown in the client detail page)
detectx.clienttitle does not exist in the locale.json. You may want to change that to detectx.title (this controls the name in the dropdown in the client detail page)
| 'detectx-tab' => array('view' => 'detectx_tab', 'i18n' => 'detectx.clienttitle', 'badge' => 'detectx-cnt'), | ||
| ), | ||
| 'listings' => array( | ||
| 'detectx' => array('view' => 'detectx_listing', 'i18n' => 'detectx.clienttitle'), |
bochoven
Dec 16, 2017
Contributor
detectx.clienttitle does not exist in the locale.json. You may want to change that to detectx.title (this controls the name in the dropdown in the listing menu)
detectx.clienttitle does not exist in the locale.json. You may want to change that to detectx.title (this controls the name in the dropdown in the listing menu)
| { | ||
| parent::__construct('id', 'detectx'); //primary key, tablename | ||
| $this->rs['id'] = ''; | ||
| $this->rs['serial_number'] = $serial; |
bochoven
Dec 16, 2017
Contributor
Please add a UNIQUE rt statement: $this->rt['serial_number'] = 'VARCHAR(255) UNIQUE';
Please add a UNIQUE rt statement: $this->rt['serial_number'] = 'VARCHAR(255) UNIQUE';
|
|
||
| // Add indexes | ||
| $this->idx[] = array('numberofissues'); | ||
| $this->idx[] = array('status'); |
bochoven
Dec 16, 2017
Contributor
I would add an index on search date too.
I would add an index on search date too.
|
|
||
| <tbody> | ||
| <tr> | ||
| <td data-i18n="listing.loading" colspan="10" class="dataTables_empty"></td> |
tuxudo
Dec 18, 2017
Contributor
colspan= should be equal to the total amount of columns in the listing.
colspan= should be equal to the total amount of columns in the listing.
Updated model for new data
Will pull a json file from DetectX granted the admin deploying this module places it in the cache dir.