Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
- Introduced ControlROMFeatureSet to define control ROM features alon…
…g with other properties in ROMInfo - Currently ControlROMFeatureSet includes only reverb ROM type which should correspond the hardware unit revision depending on the control ROM version
- Loading branch information
Showing
2 changed files
with
29 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71ae492
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is odd, as it introduces a struct that is essentially a boolean... Also, it produces warnings that a global constructor is needed.
Here's a link to a discussion on the associated ScummVM commit:
scummvm/scummvm@8c5f675
I've made a patch to simplify the code and remove the warning here:
http://pastie.org/9372949
However, I'm unsure of what the original author wants to do... are more fields going to be added to that struct? If not, there's no real point keeping it around, IMHO.