Skip to content

/ hereR

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezones in route(), route_matrix(), isoline() and connection() ignored #28

Closed
munterfinger opened this issue Jan 2, 2020 · 1 comment
Closed

Timezones in route(), route_matrix(), isoline() and connection() ignored #28

munterfinger opened this issue Jan 2, 2020 · 1 comment
Assignees
@munterfinger
Labels
bug

Comments

@munterfinger
Copy link
Owner

@munterfinger munterfinger commented Jan 2, 2020

The timezones passed into the route(), route_matrix(), isoline() and connection() functions by the datetime parameter are ignored.
@munterfinger munterfinger self-assigned this Jan 2, 2020
@munterfinger munterfinger added the bug label Jan 2, 2020
@munterfinger
Copy link
Owner Author

@munterfinger munterfinger commented Jan 2, 2020

Function for printing the timezone, departure and arrival time:

print_dep_arr <- function(x) {
  message(
    sprintf("TZ: %s, Dep: %s, Arr: %s\n",
            attr(x$departure, "tzone"),
            x$departure,
            x$arrival)
  )
}

Construct a dummy data set:

library(hereR)
o = geocode("Hardstrasse 48, 8004 Zürich, Schweiz")
d = geocode("Schweighofstrasse 190, 8045 Zürich, Schweiz")
datetime = as.POSIXct("2020-01-02 22:00:00 CET", tz = "Europe/Zurich")

Testing connection() with "Europe/Zurich":

# Departure
c_dep <- connection(o, d, datetime = datetime, results = 1, arrival = FALSE, summary = TRUE)
print_dep_arr(c_dep)
#> TZ: Europe/Zurich, Dep: 2020-01-02 22:00:00, Arr: 2020-01-02 22:26:00

# Arrival
c_arr <- connection(o, d, datetime = datetime, results = 1, arrival = TRUE, summary = TRUE)
print_dep_arr(c_arr)
#> TZ: Europe/Zurich, Dep: 2020-01-02 21:30:00, Arr: 2020-01-02 21:56:00

Testing route() with "Australia/Melbourne":

attr(datetime, "tzone") <- "Australia/Melbourne"
# Departure
r_dep <- route(o, d, datetime = datetime, arrival = FALSE)
print_dep_arr(r_dep)
#> TZ: Australia/Melbourne, Dep: 2020-01-03 08:00:00, Arr: 2020-01-03 08:07:51

# Arrival
r_arr <- route(o, d, datetime = datetime, arrival = TRUE)
print_dep_arr(r_arr)
#> TZ: Australia/Melbourne, Dep: 2020-01-03 07:52:09, Arr: 2020-01-03 08:00:00

Testing route_matrix() with "America/Los_Angeles":

attr(datetime, "tzone") <- "America/Los_Angeles"

# Departure
r_mat <- route_matrix(o, d, datetime = datetime)
print_dep_arr(r_mat)
#> TZ: America/Los_Angeles, Dep: 2020-01-02 13:00:00, Arr: 2020-01-02 13:07:51

Testing isoline() with "UTC":

attr(datetime, "tzone") <- "UTC"

# Departure
i_dep <- isoline(o, datetime = datetime, arrival = FALSE)
#> Linking to GEOS 3.7.2, GDAL 2.4.2, PROJ 5.2.0
print_dep_arr(i_dep)
#> TZ: UTC, Dep: 2020-01-02 21:00:00, Arr: 2020-01-02 21:05:00
#> TZ: UTC, Dep: 2020-01-02 21:00:00, Arr: 2020-01-02 21:10:00
#> TZ: UTC, Dep: 2020-01-02 21:00:00, Arr: 2020-01-02 21:15:00
#> TZ: UTC, Dep: 2020-01-02 21:00:00, Arr: 2020-01-02 21:20:00
#> TZ: UTC, Dep: 2020-01-02 21:00:00, Arr: 2020-01-02 21:25:00
#> TZ: UTC, Dep: 2020-01-02 21:00:00, Arr: 2020-01-02 21:30:00

# Arrival
i_arr <- isoline(o, datetime = datetime, arrival = TRUE)
print_dep_arr(i_arr)
#> TZ: UTC, Dep: 2020-01-02 20:55:00, Arr: 2020-01-02 21:00:00
#> TZ: UTC, Dep: 2020-01-02 20:50:00, Arr: 2020-01-02 21:00:00
#> TZ: UTC, Dep: 2020-01-02 20:45:00, Arr: 2020-01-02 21:00:00
#> TZ: UTC, Dep: 2020-01-02 20:40:00, Arr: 2020-01-02 21:00:00
#> TZ: UTC, Dep: 2020-01-02 20:35:00, Arr: 2020-01-02 21:00:00
#> TZ: UTC, Dep: 2020-01-02 20:30:00, Arr: 2020-01-02 21:00:00

Now the timezones from the "datetime" input is taken to parse
datetimes from the APIs. If no "tzone" attribute on the "datetime"
(POSIXct object) is definded, Sys.timezone is used.

Session info 
devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.6.1 (2019-07-05)
#>  os       macOS Catalina 10.15.1      
#>  system   x86_64, darwin15.6.0        
#>  ui       X11                         
#>  language (EN)                        
#>  collate  de_CH.UTF-8                 
#>  ctype    de_CH.UTF-8                 
#>  tz       Europe/Zurich               
#>  date     2020-01-02                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date       lib source        
#>  assertthat    0.2.1      2019-03-21 [1] CRAN (R 3.6.0)
#>  backports     1.1.5      2019-10-02 [1] CRAN (R 3.6.0)
#>  callr         3.4.0      2019-12-09 [1] CRAN (R 3.6.0)
#>  class         7.3-15     2019-01-01 [1] CRAN (R 3.6.1)
#>  classInt      0.4-2      2019-10-17 [1] CRAN (R 3.6.0)
#>  cli           2.0.0      2019-12-09 [1] CRAN (R 3.6.0)
#>  crayon        1.3.4      2017-09-16 [1] CRAN (R 3.6.0)
#>  curl          4.3        2019-12-02 [1] CRAN (R 3.6.0)
#>  data.table    1.12.8     2019-12-09 [1] CRAN (R 3.6.0)
#>  DBI           1.1.0      2019-12-15 [1] CRAN (R 3.6.0)
#>  desc          1.2.0      2018-05-01 [1] CRAN (R 3.6.0)
#>  devtools      2.2.1      2019-09-24 [1] CRAN (R 3.6.0)
#>  digest        0.6.23     2019-11-23 [1] CRAN (R 3.6.0)
#>  e1071         1.7-3      2019-11-26 [1] CRAN (R 3.6.0)
#>  ellipsis      0.3.0      2019-09-20 [1] CRAN (R 3.6.0)
#>  evaluate      0.14       2019-05-28 [1] CRAN (R 3.6.0)
#>  fansi         0.4.0      2018-10-05 [1] CRAN (R 3.6.0)
#>  fs            1.3.1      2019-05-06 [1] CRAN (R 3.6.0)
#>  glue          1.3.1      2019-03-12 [1] CRAN (R 3.6.0)
#>  hereR       * 0.2.1.9000 2020-01-02 [1] local         
#>  htmltools     0.4.0      2019-10-04 [1] CRAN (R 3.6.0)
#>  jsonlite      1.6        2018-12-07 [1] CRAN (R 3.6.0)
#>  KernSmooth    2.23-16    2019-10-15 [1] CRAN (R 3.6.0)
#>  knitr         1.26       2019-11-12 [1] CRAN (R 3.6.0)
#>  lwgeom        0.1-7      2019-05-06 [1] CRAN (R 3.6.0)
#>  magrittr      1.5        2014-11-22 [1] CRAN (R 3.6.0)
#>  memoise       1.1.0      2017-04-21 [1] CRAN (R 3.6.0)
#>  pkgbuild      1.0.6      2019-10-09 [1] CRAN (R 3.6.0)
#>  pkgload       1.0.2      2018-10-29 [1] CRAN (R 3.6.0)
#>  prettyunits   1.0.2      2015-07-13 [1] CRAN (R 3.6.0)
#>  processx      3.4.1      2019-07-18 [1] CRAN (R 3.6.0)
#>  ps            1.3.0      2018-12-21 [1] CRAN (R 3.6.0)
#>  R6            2.4.1      2019-11-12 [1] CRAN (R 3.6.0)
#>  Rcpp          1.0.3      2019-11-08 [1] CRAN (R 3.6.0)
#>  remotes       2.1.0      2019-06-24 [1] CRAN (R 3.6.0)
#>  rlang         0.4.2      2019-11-23 [1] CRAN (R 3.6.0)
#>  rmarkdown     2.0        2019-12-12 [1] CRAN (R 3.6.0)
#>  rprojroot     1.3-2      2018-01-03 [1] CRAN (R 3.6.0)
#>  sessioninfo   1.1.1      2018-11-05 [1] CRAN (R 3.6.0)
#>  sf          * 0.8-0      2019-09-17 [1] CRAN (R 3.6.0)
#>  stringi       1.4.3      2019-03-12 [1] CRAN (R 3.6.0)
#>  stringr       1.4.0      2019-02-10 [1] CRAN (R 3.6.0)
#>  testthat      2.3.1      2019-12-01 [1] CRAN (R 3.6.0)
#>  units         0.6-5      2019-10-08 [1] CRAN (R 3.6.0)
#>  usethis       1.5.1      2019-07-04 [1] CRAN (R 3.6.0)
#>  withr         2.1.2      2018-03-15 [1] CRAN (R 3.6.0)
#>  xfun          0.11       2019-11-12 [1] CRAN (R 3.6.0)
#>  yaml          2.2.0      2018-07-25 [1] CRAN (R 3.6.0)
#> 
#> [1] /Library/Frameworks/R.framework/Versions/3.6/Resources/library
@munterfinger munterfinger mentioned this issue Jan 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munterfinger munterfinger

Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Switch dep arr
1 participant
@munterfinger
You can’t perform that action at this time.