Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwgeom no longer exports st_make_valid #38

Closed
edzer opened this issue Apr 10, 2020 · 1 comment
Closed

lwgeom no longer exports st_make_valid #38

edzer opened this issue Apr 10, 2020 · 1 comment
Assignees
Labels

Comments

@edzer
Copy link

@edzer edzer commented Apr 10, 2020

... but sf does. This will break hereR with e.g.

  > test_check("hereR")
  ── 1. Error: isoline works  ────────────────────────────────────────────────────
  'st_make_valid' is not an exported object from 'namespace:lwgeom'
  Backtrace:
   1. hereR::isoline(poi = poi, aggregate = TRUE)
   2. lwgeom::st_make_valid
   3. base::getExportedValue(pkg, name)

Please fix and resubmit to CRAN to avoid errors in CRAN checks.

@munterfinger
Copy link
Owner

@munterfinger munterfinger commented Apr 10, 2020

Thanks for reporting - fixed and resubmitted to CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.