Uncaught TypeError: Cannot read property 'tags' of undefined

[dspies-leapyear]

I'm running into this issue: atom/atom#17010
when I toggle on split-diff.

Instead of getting the old file, the RHS is empty (visible in the screenshot. The LHS is the file as it is currently with green markings for lines which have changed). It seems to only happen on some files within the repo, but it happens consistently on those.

---

macOS High Sierra 10.13.6

$ atom --version
Atom    : 1.31.2
Electron: 2.0.7
Chrome  : 61.0.3163.100
Node    : 8.9.3

$ apm show split-diff
split-diff
├── 1.5.3
├── https://github.com/mupchrch/split-diff
├── A split pane diff tool.
├── 496758 downloads
└── 605 stars

[jaibatrik]

Yeah, this has rendered the package unusable for me.

[philayres]

Just started happening for me too.

I get the following stack trace in the error:

/usr/share/atom/resources/app/src/text-mate-language-mode.js:748
Hide Stack Trace
TypeError: Cannot read property 'tags' of undefined
    at TextMateHighlightIterator.seek (/usr/share/atom/resources/app/src/text-mate-language-mode.js:748:46)
    at ScreenLineBuilder.buildScreenLines (/usr/share/atom/resources/app/node_modules/text-buffer/lib/screen-line-builder.js:84:58)
    at DisplayLayer.getScreenLines (/usr/share/atom/resources/app/node_modules/text-buffer/lib/display-layer.js:643:41)
    at DisplayLayer.getScreenLine (/usr/share/atom/resources/app/node_modules/text-buffer/lib/display-layer.js:639:60)
    at TextEditor.screenLineForScreenRow (/usr/share/atom/resources/app/src/text-editor.js:1278:36)
    at TextEditorComponent.requestHorizontalMeasurement (/usr/share/atom/resources/app/src/text-editor-component.js:2255:47)
    at TextEditorComponent.updateSyncBeforeMeasuringContent (/usr/share/atom/resources/app/src/text-editor-component.js:382:18)
    at TextEditorComponent.updateSync (/usr/share/atom/resources/app/src/text-editor-component.js:276:16)
    at etch.getScheduler.updateDocument (/usr/share/atom/resources/app/src/text-editor-component.js:226:46)
    at ViewRegistry.performDocumentUpdate (/usr/share/atom/resources/app/src/view-registry.js:238:13)

My guess is that is actually a red-herring, and is maybe due to the document being undefined (based on the fact the diff pane appears blank), breaking the first thing that tries to touch it.

[philayres]

I think that there may be an issue with git somewhere. I just tried the git-time-machine package and it complains on the last commit with Could not retrieve revision for <filename> (128) but works for previous commits.

Perhaps there is a common issue between the two packages.

I have checked git diff on the command line and it works fine. Also meld version control diff works. So I'm fairly sure it is not an issue with my git repo.

My git version is 2.7.4

[dspies-leapyear]

$ git --version
git version 2.17.2 (Apple Git-113)

[hSaria]

Same issue here. I've had to force-install the 1.5.2 version.

[dspies-leapyear]

@hSaria How do you do that?

[hSaria]

@dspies-leapyear on terminal, type
apm install split-diff@1.5.2

You can do the same for any package, just run apm list to list all packages, then use the apm install command with the format package-name@version-number.

[peter92427]

Happens to me too, see above issue #18590 for the report.
It seems it depends on the contents of the pasted text.

[multinerd]

[Enter steps to reproduce:]

1. Open Atom
2. From toolbar Packages > Split Diff > Toggle
3. Error thrown when:
   • Merely clicking on the right side
   • Trying to paste (via keyboard) on right side

Atom: 1.33.1 x64
Electron: 2.0.16
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core

Stack Trace

Uncaught TypeError: Cannot read property 'tags' of undefined

At C:\Users\mikeh\AppData\Local\atom\app-1.33.1\resources\app\static\<embedded>:11

TypeError: Cannot read property 'tags' of undefined
    at TextMateHighlightIterator.seek (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:11:560161)
    at ScreenLineBuilder.buildScreenLines (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:14:1102810)
    at DisplayLayer.getScreenLines (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:14:89306)
    at DisplayLayer.getScreenLine (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:14:89203)
    at TextEditor.screenLineForScreenRow (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:11:13891)
    at TextEditorComponent.screenPositionForPixelPosition (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:11:107298)
    at TextEditorComponent.screenPositionForMouseEvent (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:11:98589)
    at TextEditorComponent.didMouseDownOnContent (~/AppData/Local/atom/app-1.33.1/resources/app/static/<embedded>:11:95149)

Commands

     -1:18.9.0 split-diff:toggle (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -1:13.1.0 core:paste (input.hidden-input)
     -1:03.9.0 core:select-all (input.hidden-input)
  3x -1:03.7.0 core:paste (input.hidden-input)
     -0:52.6.0 split-diff:toggle (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:48.6.0 core:paste (input.hidden-input)

Non-Core Packages

language-batchfile 0.7.5 
split-diff 1.5.3 

[mupchrch]

I still can't reproduce this problem. @hSaria are you saying that the previous version of the package works and no error is thrown? Does syntax highlighting of the right side work?

[hSaria]

@mupchrch Yeah, the previous version works fine but it does not set the grammar of the document automatically. If, for example, I have a document with the Python grammar/language set, when I open a split-diff tab, it will be set to plain-text. Apart from that, everything else is fine.

[hSaria]

I've fixed it and done a bit of testing. Works as expected (editor2 gets the grammar of editor1 without any issues). The pull request is #157