Close Pane and untitled file on toggle

[markediez]

At some point, it simply gets annoying to close the untitled file (asks if I want to save changes) when I'm done diffing.

[mupchrch]

Do you think toggle should auto close the untitled file, or do you just not want it to prompt you to save on close?

[cliffordfajardo]

Personally, I don't mind the prompt. I'm not familiar with Atom's API for plugin development, but if there was an option in the settings like a checkbox

• on diff tab close, show confirm dialog box

[mupchrch]

I am thinking about having it not prompt you to save if the editor was auto opened by split-diff: toggle. If the user manually opened the editor, then it would still prompt as it does now.

@cliffordfajardo That would be straightforward, but I am afraid of adding too many settings so that the settings list becomes unnecessarily bloated. I am willing to be convinced though!

[markediez]

@mupchrch Sorry for the late reply but yes. Essentially that plus closing the pane it created.

Just to clarify this is the suggestion:

split-diff:Toggle -> Open new pane with the diff
split-diff:Toggle -> Close diff and pane without prompting to save

[mupchrch]

Toggle will close panes that were opened by split-diff. Manually closing the tab will still prompt the user. Thanks for the feedback!