Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST FIRST] New icon; dialog asking for feedback. #560

Closed
wants to merge 1 commit into from

Conversation

easyaspi314
Copy link
Contributor

See #550.

This is the new Material-inspired recolor designed by me.

On first launch, SplashActivity will present the user with an
AlertDialog prompting them to vote on the icon. Test first.

I know it is not perfect, I just don’t want to build an XML file.

Poll results will be here:

https://docs.google.com/forms/d/1F2stkHvb0Rx5vfmaz50OtTfT73XjHK2GEXZj9a_x-yw/viewanalytics?usp=form_confirm

See mupen64plus-ae#550.

This is the new Material-inspired recolor designed by me.

On first launch, SplashActivity will present the user with an
AlertDialog prompting them to vote on the icon. Test first.

I know it is not perfect, I just don’t want to build an XML file.

Poll results will be here:

https://docs.google.com/forms/d/1F2stkHvb0Rx5vfmaz50OtTfT73XjHK2GEXZj9a_
x-yw/viewanalytics?usp=form_confirm
@fzurita
Copy link
Member

fzurita commented May 3, 2016

Cool, I'll check this tonight

@easyaspi314
Copy link
Contributor Author

I know you aren't going to believe this, but I am actually going to try to make a build!

I figured, "what the hell."
I will tell you if it works. I have it on a case-sensitive virtual drive, so it might work.

@fzurita
Copy link
Member

fzurita commented May 3, 2016

Nice, good luck!

@easyaspi314
Copy link
Contributor Author

easyaspi314 commented May 3, 2016

GOD, NDK takes forever to build! (And now I have to wait for x86) 😡
Does new_dynarec usually get stuck there for a while? Of course, whenever you say something it works. 😕

@fzurita
Copy link
Member

fzurita commented May 3, 2016

Yes, it takes a while to build. It really helps to have a nice PC.

@easyaspi314
Copy link
Contributor Author

Eclipse must hate me. I rage quit.

@fzurita
Copy link
Member

fzurita commented May 3, 2016

With my old PC it took like 20 to 30 minutes to build. I got a new PC in the end and it take like 4 minutes.

@easyaspi314
Copy link
Contributor Author

easyaspi314 commented May 3, 2016

@fzurita it isn't that (although it is very slow, I have a MacBook Mid-2009 with 4gb of RAM, 2.13ghz Core 2 Duo, and El Cap). It is spitting out compiler errors.

It looks like issues with the Preference library. I will rename it and see if it helps.

@fzurita
Copy link
Member

fzurita commented May 3, 2016

Oh... Although, that is slow. That's slower than what I had before I upgraded. Having an SSD helps a lot.

@fzurita
Copy link
Member

fzurita commented May 3, 2016

Also, I'm not sure about the build process in a Mac. I know it works well with Linux and windows.

@easyaspi314
Copy link
Contributor Author

easyaspi314 commented May 3, 2016

Having an SSD helps a lot.

Having some USD ($) helps a lot too.

I am broke. 😞

Though honestly, it isn't that bad. Macs run pretty fast as long as you don't use Chrome or something. I can legitimately multitask on it, with AS running in the background and FF, TextEdit, Gimp, etc.

I am going to try building with precompiled libs.

Eclipse legitimately hates me.

Screw it. Can you make one for me? 😢

@easyaspi314
Copy link
Contributor Author

easyaspi314 commented May 3, 2016 via email

@fzurita
Copy link
Member

fzurita commented May 3, 2016

Yeah, sure. A few hours from know when my kids go to sleep.

@easyaspi314
Copy link
Contributor Author

A few hours from now when my kids go to sleep.

Or a few years! You never know! 😆😄

@fzurita
Copy link
Member

fzurita commented May 3, 2016

Lol

@easyaspi314
Copy link
Contributor Author

Or is that one of those things developers say when they are planning to abandon a project but don't want to say so? 😄

@fzurita
Copy link
Member

fzurita commented May 3, 2016

Lol, nope, I've been working on this for a while. My oldest is 3. I have small bursts of time where I can really contribute.

@easyaspi314
Copy link
Contributor Author

easyaspi314 commented May 3, 2016

Yeah the developer for my backup phone's ROM is weird. He will contribute for a day or two then disappear.
I tag him in my XDA posts, PM him, nothing. Then one day he is just there.

@fzurita
Copy link
Member

fzurita commented May 4, 2016

Ok, just tried it. Several build errors but I was able to get it to compile.

First things first. New icon looks good in my screen.

Second. Dialogs will not work well in the SpashActivity unless you block the GalleryActivity from showing until the dialog is dismissed.

It's probably easier to place the dialog in the GalleryActivity itself.

@fzurita
Copy link
Member

fzurita commented May 4, 2016

Once you fix the icon size issue, I can fix the build errors and place the dialog in the right activity.

@easyaspi314
Copy link
Contributor Author

Ok

@fzurita
Copy link
Member

fzurita commented May 12, 2016

Did you ever get a chance to update the icon to be the right size?

@easyaspi314
Copy link
Contributor Author

Abooouuuut thaaaaaaaaaaat.............

I really wanted to finish it but I have two weeks of school left until
graduation, which is pretty much taken up by finals and senior week.

I'll do what I can.
On May 12, 2016 6:43 PM, "Francisco Zurita" notifications@github.com
wrote:

Did you ever get a chance to update the icon to be the right size?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#560 (comment)

@fzurita
Copy link
Member

fzurita commented May 13, 2016

No hurry.

@easyaspi314
Copy link
Contributor Author

I wish. :(
On May 13, 2016 12:29 PM, "Francisco Zurita" notifications@github.com
wrote:

No hurry.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#560 (comment)

@fzurita fzurita force-pushed the master branch 4 times, most recently from 9f7c3d8 to 41c5b7b Compare October 25, 2017 20:30
@fzurita fzurita force-pushed the master branch 3 times, most recently from 7f7b27c to 5aee9ee Compare November 28, 2017 22:41
@fzurita fzurita force-pushed the master branch 3 times, most recently from d3e88fb to e88b88e Compare January 24, 2018 06:26
@fzurita fzurita force-pushed the master branch 5 times, most recently from b97b2ed to be53cd9 Compare February 20, 2018 19:04
@fzurita fzurita force-pushed the master branch 2 times, most recently from c5b4e67 to 9e5a333 Compare January 17, 2019 04:29
@fzurita fzurita force-pushed the master branch 2 times, most recently from b1f03fa to 13f77de Compare February 3, 2019 22:59
@fzurita fzurita force-pushed the master branch 2 times, most recently from c8c7f4f to ab03140 Compare January 30, 2020 02:16
@fzurita fzurita closed this Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants