New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_migration method def changed to create_letsrate_migration to avoid collision with rails create_migration method name #69

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@dasibre

dasibre commented May 14, 2014

create_migration method def changed to create_letsrate_migration to avoid collision with rails create_migration method name
/Users/jnaadjie/.rvm/gems/ruby-2.1.1@bleedingedge/gems/letsrate-1.0.9/lib/generators/letsrate/letsrate_generator.rb:37:in create_migration': wrong number of arguments (3 for 0) (ArgumentError) from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/railties-4.1.0/lib/rails/generators/migration.rb:63:inmigration_template'
from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@bleedingedge/gems/letsrate-1.0.9/lib/generators/letsrate/letsrate_generator.rb:33:in create_cacheable_migration' from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/command.rb:27:inrun'
from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/invocation.rb:126:in invoke_command' from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/invocation.rb:133:inblock in invoke_all'
from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/invocation.rb:133:in each' from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/invocation.rb:133:inmap'
from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/invocation.rb:133:in invoke_all' from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/group.rb:232:indispatch'
from /Users/jnaadjie/.rvm/gems/ruby-2.1.1@global/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'

create_migration method def changed to create_letsrate_migration to a…
…void collision with rails create_migration method
@wazery

This comment has been minimized.

Show comment
Hide comment
@wazery

wazery Jul 6, 2014

Contributor

Could you please fix the error with this PR?

Contributor

wazery commented Jul 6, 2014

Could you please fix the error with this PR?

@maximbond

This comment has been minimized.

Show comment
Hide comment
@maximbond

maximbond Jul 17, 2014

Same problem. Maybe someone could post the right migration file so we could move over?

maximbond commented Jul 17, 2014

Same problem. Maybe someone could post the right migration file so we could move over?

@wazery

This comment has been minimized.

Show comment
Hide comment
@wazery

wazery Jul 17, 2014

Contributor

@Macks111 I forked the repo and fixed this issur, and I will keep maintaining (till the original author is back and be active again) and will develop on my fork. Also I will push some modifications soon to add some IMDB style rating features, kindly find it now on https://github.com/wazery/letsrate

Contributor

wazery commented Jul 17, 2014

@Macks111 I forked the repo and fixed this issur, and I will keep maintaining (till the original author is back and be active again) and will develop on my fork. Also I will push some modifications soon to add some IMDB style rating features, kindly find it now on https://github.com/wazery/letsrate

@luizpicolo

This comment has been minimized.

Show comment
Hide comment
@luizpicolo

luizpicolo commented Sep 6, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment