Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove styles that prevent users from seeing default browser focus state #8

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@ktbee
Copy link
Contributor

ktbee commented Oct 27, 2019

Hello! Thank you for making such a beautiful resume theme available. It is great to see the aria labels on the header icons, but I noticed another accessibility issue with them. The header icons and the down arrow in this theme have had their default focus state styling removed, so it's not possible to see when you have tabbed to them using keyboard navigation..

It's generally not considered good practice to set outline to 0, so my changes are just to remove that styling on .header icons a and .down. If you let me know your original reasons for removing it, I can try to address those as well (perhaps you don't like see it stay on anchor links after clicking?).

Thank you for taking a look and looking forward to hearing your thoughts on this!

@murraco murraco merged commit c58c599 into murraco:master Oct 28, 2019
5 checks passed
5 checks passed
Header rules - jekyll-theme-minimal-resume No header rules processed
Details
Pages changed - jekyll-theme-minimal-resume 1 new file uploaded
Details
Redirect rules - jekyll-theme-minimal-resume No redirect rules processed
Details
Mixed content - jekyll-theme-minimal-resume No mixed content detected
Details
netlify/jekyll-theme-minimal-resume/deploy-preview Deploy preview ready!
Details
@ktbee ktbee deleted the ktbee:restore-outline-accessibility branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.