Remove styles that prevent users from seeing default browser focus state#8
Merged
murraco merged 1 commit intomurraco:masterfrom Oct 28, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for making such a beautiful resume theme available. It is great to see the aria labels on the header icons, but I noticed another accessibility issue with them. The header icons and the down arrow in this theme have had their default focus state styling removed, so it's not possible to see when you have tabbed to them using keyboard navigation..
It's generally not considered good practice to set
outlineto 0, so my changes are just to remove that styling on.header icons aand.down. If you let me know your original reasons for removing it, I can try to address those as well (perhaps you don't like see it stay on anchor links after clicking?).Thank you for taking a look and looking forward to hearing your thoughts on this!